Skip to content

Conversation

@jwtty
Copy link
Collaborator

@jwtty jwtty commented Apr 22, 2025

Description of your changes

  1. When updateRun is stuck waiting for a cluster update to finish or waiting for after-stage tasks to complete, we mark updateRun Progressing condition to false and add corresponding reacon.
  2. Add updateRun status metrics based on updateRun condition. The metric contains 5 labels: name, generation, condition, status and reason. The value is the timestamp when the status metric is emitted.

Generated metrics look like:

# TYPE fleet_workload_update_run_status_last_timestamp_seconds gauge
fleet_workload_update_run_status_last_timestamp_seconds{condition="Succeeded",generation="1",name="example-run",reason="UpdateRunSucceeded",status="True"} 1.7452803474895709e+09

Fixes #

I have:

  • Run make reviewable to ensure this PR is ready for review.

How has this code been tested

Special notes for your reviewer

@jwtty jwtty force-pushed the updaterun-metrics branch from 3fdfab7 to be7b78a Compare April 22, 2025 01:50
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
@jwtty jwtty force-pushed the updaterun-metrics branch from be7b78a to eede6d9 Compare April 22, 2025 23:11
Signed-off-by: Wantong Jiang <wantjian@microsoft.com>
@jwtty jwtty force-pushed the updaterun-metrics branch from a809542 to 00ca14e Compare April 23, 2025 04:11
@jwtty jwtty merged commit 376572c into kubefleet-dev:main Apr 23, 2025
19 of 20 checks passed
@jwtty jwtty deleted the updaterun-metrics branch April 23, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants