Fix PointLight infinite radius shader overflow(#2566) #2570
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clamps infinite, negative, or Not a Number radius to Float.MAX_VALUE / 4f to prevent type overflow in shaders, as discussed in jMonkeyEngine#2566.
codex128
requested changes
Dec 1, 2025
| radius = Float.MAX_VALUE; | ||
|
|
||
| // Fix #2566 - Prevent shader overflow with infinite or invalid radius | ||
| if (radius == Float.POSITIVE_INFINITY || radius < 0f || Float.isNaN(radius)) { |
Contributor
There was a problem hiding this comment.
Better to throw an exception on negative or NaN radius, since both are meaningless as radii. Negative radius already throws an exception previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #2566
The previous workaround set an infinite radius to
Float.MAX_VALUE, which can still cause overflow in shader math.This Pull request updates the following:
Float.MAX_VALUE / 4fI tested this locally, no overflow issues.
First-time contributor for a class project.