Skip to content

Fix PointLight infinite radius shader overflow(#2566) #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hayden9329 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix PointLight infinite radius shader overflow(#2566) #2570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions jme3-core/src/main/java/com/jme3/light/PointLight.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,11 +165,11 @@ public final void setRadius(float radius) {
if (radius < 0) {
throw new IllegalArgumentException("Light radius cannot be negative");
}

if (radius == Float.POSITIVE_INFINITY) {
radius = Float.MAX_VALUE;

// Fix #2566 - Prevent shader overflow with infinite or invalid radius
if (radius == Float.POSITIVE_INFINITY || radius < 0f || Float.isNaN(radius)) {
Copy link
Contributor

@codex128 codex128 Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to throw an exception on negative or NaN radius, since both are meaningless as radii. Negative radius already throws an exception previously.

radius = Float.MAX_VALUE / 4f; // Safe large value, avoids overflow in shaders
}

this.radius = radius;
if (radius != 0f) {
this.invRadius = 1f / radius;
Expand Down
Loading