Skip to content

Conversation

@h2zero
Copy link
Owner

@h2zero h2zero commented Nov 19, 2024

Fixes #234

@iranl
Copy link
Contributor

iranl commented Nov 21, 2024

I believe this issue was introduced in a recent update of ESP-IDF 5.3.
There is an issue about this here espressif/esp-idf#14840, which is already fixed by espressif/esp-nimble@ca6c617.

So not sure if this change on the side of esp-nimble-cpp is needed (at least not long term).

@h2zero
Copy link
Owner Author

h2zero commented Nov 21, 2024

Thanks, it will be needed as this commonly breaks due to NimBLE defining min/max in headers and conflicting anywhere we #include <string>. I'm inclined to keep this change here.

@h2zero h2zero merged commit 4a57432 into master Nov 26, 2024
94 checks passed
@h2zero h2zero deleted the compile-fixes branch November 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't compile on IDF 5.3

3 participants