Skip to content

Retain platform-specific timestamp field that are being added in bug 1961012 #5446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienw merged 2 commits into from
May 13, 2025
Merged

Retain platform-specific timestamp field that are being added in bug 1961012 #5446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f23392b
Retain platform-specific timestamp field that are being added in bug …
mstange Mar 20, 2025
372c89d
Merge branch 'main' into push-myvkwuoomyrk
julienw May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/profile-logic/process-profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1697,6 +1697,12 @@ export function processGeckoProfile(geckoProfile: GeckoProfile): Profile {
const meta: ProfileMeta = {
interval: geckoProfile.meta.interval,
startTime: geckoProfile.meta.startTime,
startTimeAsClockMonotonicNanosecondsSinceBoot:
geckoProfile.meta.startTimeAsClockMonotonicNanosecondsSinceBoot,
startTimeAsMachAbsoluteTimeNanoseconds:
geckoProfile.meta.startTimeAsMachAbsoluteTimeNanoseconds,
startTimeAsQueryPerformanceCounterValue:
geckoProfile.meta.startTimeAsQueryPerformanceCounterValue,
abi: geckoProfile.meta.abi,
extensions: extensions,
misc: geckoProfile.meta.misc,
Expand Down
18 changes: 18 additions & 0 deletions src/test/unit/__snapshots__/profile-conversion.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,6 +563,9 @@ Object {
"sourceURL": undefined,
"stackwalk": 1,
"startTime": 0,
"startTimeAsClockMonotonicNanosecondsSinceBoot": undefined,
"startTimeAsMachAbsoluteTimeNanoseconds": undefined,
"startTimeAsQueryPerformanceCounterValue": undefined,
"symbolicated": true,
"toolkit": undefined,
"updateChannel": undefined,
Expand Down Expand Up @@ -86311,6 +86314,9 @@ Object {
"sourceURL": undefined,
"stackwalk": 1,
"startTime": 0,
"startTimeAsClockMonotonicNanosecondsSinceBoot": undefined,
"startTimeAsMachAbsoluteTimeNanoseconds": undefined,
"startTimeAsQueryPerformanceCounterValue": undefined,
"symbolicated": true,
"toolkit": undefined,
"updateChannel": undefined,
Expand Down Expand Up @@ -449906,6 +449912,9 @@ Object {
"sourceURL": undefined,
"stackwalk": 1,
"startTime": 2574592839.818,
"startTimeAsClockMonotonicNanosecondsSinceBoot": undefined,
"startTimeAsMachAbsoluteTimeNanoseconds": undefined,
"startTimeAsQueryPerformanceCounterValue": undefined,
"symbolicated": true,
"toolkit": undefined,
"updateChannel": undefined,
Expand Down Expand Up @@ -456166,6 +456175,9 @@ Object {
"sourceURL": undefined,
"stackwalk": 1,
"startTime": 2782992.2430000002,
"startTimeAsClockMonotonicNanosecondsSinceBoot": undefined,
"startTimeAsMachAbsoluteTimeNanoseconds": undefined,
"startTimeAsQueryPerformanceCounterValue": undefined,
"symbolicated": true,
"toolkit": undefined,
"updateChannel": undefined,
Expand Down Expand Up @@ -471051,6 +471063,9 @@ Object {
"sourceURL": undefined,
"stackwalk": 1,
"startTime": 36556170.907,
"startTimeAsClockMonotonicNanosecondsSinceBoot": undefined,
"startTimeAsMachAbsoluteTimeNanoseconds": undefined,
"startTimeAsQueryPerformanceCounterValue": undefined,
"symbolicated": true,
"toolkit": undefined,
"updateChannel": undefined,
Expand Down Expand Up @@ -477245,6 +477260,9 @@ Object {
"sourceURL": undefined,
"stackwalk": 1,
"startTime": 115539936.601,
"startTimeAsClockMonotonicNanosecondsSinceBoot": undefined,
"startTimeAsMachAbsoluteTimeNanoseconds": undefined,
"startTimeAsQueryPerformanceCounterValue": undefined,
"symbolicated": true,
"toolkit": undefined,
"updateChannel": undefined,
Expand Down
3 changes: 3 additions & 0 deletions src/test/unit/__snapshots__/profile-upgrading.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,9 @@ Object {
"sourceURL": undefined,
"stackwalk": 1,
"startTime": 2574592839.818,
"startTimeAsClockMonotonicNanosecondsSinceBoot": undefined,
"startTimeAsMachAbsoluteTimeNanoseconds": undefined,
"startTimeAsQueryPerformanceCounterValue": undefined,
"symbolicated": true,
"toolkit": undefined,
"updateChannel": undefined,
Expand Down
3 changes: 3 additions & 0 deletions src/types/gecko-profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,9 @@ export type GeckoProfileShortMeta = {|
// When the main process started. Timestamp expressed in milliseconds since
// midnight January 1, 1970 GMT.
startTime: Milliseconds,
startTimeAsClockMonotonicNanosecondsSinceBoot?: number,
startTimeAsMachAbsoluteTimeNanoseconds?: number,
startTimeAsQueryPerformanceCounterValue?: number,
shutdownTime: Milliseconds | null,
categories: CategoryList,
markerSchema: GeckoMetaMarkerSchema[],
Expand Down
3 changes: 3 additions & 0 deletions src/types/profile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,6 +768,9 @@ export type ProfileMeta = {|
// When the main process started. Timestamp expressed in milliseconds since
// midnight January 1, 1970 GMT.
startTime: Milliseconds,
startTimeAsClockMonotonicNanosecondsSinceBoot?: number,
startTimeAsMachAbsoluteTimeNanoseconds?: number,
startTimeAsQueryPerformanceCounterValue?: number,
// The number of milliseconds since midnight January 1, 1970 GMT.
endTime?: Milliseconds,
// When the recording started (in milliseconds after startTime).
Expand Down