Skip to content

Conversation

@mstange
Copy link
Contributor

@mstange mstange commented May 6, 2025

This PR makes us carry the fields added in bug 1961012 through into the processed format, and adds them to the type definitions.

The corresponding change to samply's simpleperf importer is in mstange/samply#560 .

I'm making use of the startTimeAsClockMonotonicNanosecondsSinceBoot field in the merging script which I've put into #5448.

Pasting the justification from the bug here:

I would like to combine Gecko profiler marker data with Android simpleperf sample data. To make a combined profile, I need to adjust timestamps so that they're in the same space.

simpleperf uses CLOCK_MONOTONIC_RAW timestamps.
The Gecko profiler uses the TimeStamp class which, on Android, stores CLOCK_MONOTONIC_RAW values internally.
But in the profile JSON, we lose this information: profile.meta.startTime is in float seconds since the Unix epoch, and the rest of the time values is relative to the startTime.

I think it would be useful to have the CLOCK_MONOTONIC_RAW startTime in the profile JSON.

@mstange mstange force-pushed the push-myvkwuoomyrk branch from b03f519 to f23392b Compare May 8, 2025 14:20
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.03%. Comparing base (8b83c7a) to head (f23392b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5446   +/-   ##
=======================================
  Coverage   86.03%   86.03%           
=======================================
  Files         312      312           
  Lines       30365    30365           
  Branches     8299     8299           
=======================================
  Hits        26126    26126           
  Misses       3645     3645           
  Partials      594      594           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mstange mstange requested a review from canova May 8, 2025 14:30
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@julienw julienw enabled auto-merge (squash) May 13, 2025 12:49
@julienw julienw merged commit 6ba90a6 into firefox-devtools:main May 13, 2025
12 of 13 checks passed
@julienw julienw mentioned this pull request May 15, 2025
julienw added a commit that referenced this pull request May 15, 2025
[Julien Wajsberg] Relax the check about chrome profiles (#5439)
[Julien Wajsberg] Do not fail when the input isn't valid UTF-8 (#5426)
[Markus Stange] Add the marker field types "flow-id" and "terminating-flow-id" to the set of types that store indexes in the string table (#5447)
[Markus Stange] Retain platform-specific timestamp field that are being added in bug 1961012. (#5446)
[Julien Wajsberg] Use the right allocations call tree when an allocations summary is selected  (#5456)
[Julien Wajsberg] Do not use a link to display the sourceURL if it's not a proper URL (#5454)

And for locales:
kab: ZiriSut 
zh-CN: Olvcpr423
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants