Skip to content

Conversation

@DhavalGojiya
Copy link
Contributor

Description

This PR updates the Ruff target Python marker to the minimum supported version, 3.10.

Zip function changes

See reference: Ruff zip rule

tox.ini changes

See reference: Requests changelog

@cclauss
Copy link
Contributor

cclauss commented Nov 18, 2025

% ruff rule B905

While adding strict=False preserves the runtime behavior, it can obscure situations where the iterables are of unequal length. Ruff prefers to alert users so they can choose the intended behavior themselves.

  • PEP 621: Migrate from setup.py to pyproject.toml #522
    Sets zip(x, y, strict=True) instead of False because in pysolr.py, terms[0::2] and terms[1::2] will always have the same number of items and in tests/test_client.py because the stricter pytests will provide more confidence.

auto-merge was automatically disabled November 18, 2025 11:39

Head branch was pushed to by a user without write access

@DhavalGojiya
Copy link
Contributor Author

Updated.

@acdha acdha merged commit ec2ff51 into django-haystack:master Nov 18, 2025
9 checks passed
@DhavalGojiya DhavalGojiya deleted the fix/ruff-target-py-marker branch November 18, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants