Skip to content

fix: data table on blur data retention #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 3, 2025
Merged

fix: data table on blur data retention #971

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c1b0285
fix: retain selection type on blur
Elessar1802 Dec 2, 2025
d022c23
chore: bump version
Elessar1802 Dec 2, 2025
3ef21f3
Merge branch 'kubecon-2025' of github.com:devtron-labs/devtron-fe-com…
Elessar1802 Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@devtron-labs/devtron-fe-common-lib",
"version": "1.20.6-pre-51",
"version": "1.20.6-alpha-87",
"description": "Supporting common component library",
"type": "module",
"main": "dist/index.js",
Expand Down
4 changes: 2 additions & 2 deletions src/Shared/Components/SelectPicker/SelectPickerTextArea.component.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@ export const SelectPickerTextArea = ({
})
}
} else if (action === ReactSelectInputAction.inputBlur) {
if (isCreatable) {
const selectValue = value as SingleValue<SelectPickerOptionType<string>>
if (isCreatable && (!selectValue?.value || selectValue.value !== inputValue)) {
handleCreateOption(inputValue)
return
}
// Reverting input to previously selected value in case of blur event. (no-selection)
const selectValue = value as SingleValue<SelectPickerOptionType<string>>
setInputValue(selectValue?.value || '')
}
}
Expand Down
Loading