Skip to content

Conversation

@Elessar1802
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist

  • The title of the PR states what changed and the related issues number (used for the release note).
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

vivek-devtron
vivek-devtron previously approved these changes Dec 2, 2025
Copilot AI review requested due to automatic review settings December 3, 2025 10:12
Copilot finished reviewing on behalf of Elessar1802 December 3, 2025 10:13
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue with data retention when a SelectPickerTextArea component loses focus (blur event). The main change improves the logic to prevent unnecessary re-creation of already selected options.

Key Changes

  • Modified the blur event handler to only create a new option when the input value differs from the currently selected value
  • Moved the selectValue variable declaration earlier in the blur handler for better code organization
  • Updated package version from 1.21.0-pre-1 to 1.20.6-alpha-88 with associated dependency changes

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/Shared/Components/SelectPicker/SelectPickerTextArea.component.tsx Enhanced blur handler logic to conditionally create options only when input differs from selected value, preventing data loss on blur
package.json Version changed from 1.21.0-pre-1 to 1.20.6-alpha-88
package-lock.json Dependency peer relationships updated to reflect package.json version change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Elessar1802 Elessar1802 merged commit 77beb67 into kubecon-2025 Dec 3, 2025
10 checks passed
@Elessar1802 Elessar1802 deleted the fix/data-table branch December 3, 2025 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants