Fix lakeview publish to default embed_credentials to false

acceptance/workspace/lakeview/publish/out.requests.txt

@@ -0,0 +1,23 @@
+{
+  "method": "POST",
+  "path": "/api/2.0/workspace/mkdirs",
+  "body": {
+    "path": "/Users/[USERNAME]"
+  }
+}
+{
+  "method": "POST",
+  "path": "/api/2.0/lakeview/dashboards",
+  "body": {
+    "display_name": "Test Dashboard",
+    "parent_path": "/Users/[USERNAME]",
+    "warehouse_id": "test-warehouse"
+  }
+}
+{
+  "method": "POST",
+  "path": "/api/2.0/lakeview/dashboards/[DASHBOARD_ID]/published",
+  "body": {
+    "embed_credentials": false
+  }
+}

acceptance/workspace/lakeview/publish/output.txt

@@ -0,0 +1,7 @@
+
+>>> [CLI] lakeview publish [DASHBOARD_ID]
+{
+  "display_name":"Test Dashboard",
+  "embed_credentials":false,
+  "warehouse_id":"test-warehouse"
+}

acceptance/workspace/lakeview/publish/script

@@ -0,0 +1,5 @@
+$CLI workspace mkdirs /Users/tester@databricks.com
+
+dashboard_id=$($CLI lakeview create --json '{"display_name": "Test Dashboard", "parent_path": "/Users/tester@databricks.com", "warehouse_id": "test-warehouse"}' -o json | grep -o '"dashboard_id":"[^"]*"' | cut -d'"' -f4)
+
+trace $CLI lakeview publish $dashboard_id

acceptance/workspace/lakeview/publish/test.toml

@@ -0,0 +1,8 @@
+RecordRequests = true
+
+[Env]
+MSYS_NO_PATHCONV = "1"
+
+[[Repls]]
+Old = "[a-f0-9]{32}"
+New = "[DASHBOARD_ID]"

cmd/workspace/lakeview/overrides.go

@@ -0,0 +1,19 @@
+package lakeview
+
+import (
+	"github.com/databricks/databricks-sdk-go/service/dashboards"
+	"github.com/spf13/cobra"
+)
+
+func publishOverride(cmd *cobra.Command, req *dashboards.PublishRequest) {
+	originalRunE := cmd.RunE
+	cmd.RunE = func(cmd *cobra.Command, args []string) error {
+		// Force send embed_credentials even when false, otherwise the API defaults to true.
+		req.ForceSendFields = append(req.ForceSendFields, "EmbedCredentials")
+		return originalRunE(cmd, args)
+	}
+}
+
+func init() {
+	publishOverrides = append(publishOverrides, publishOverride)
+}