Fix lakeview publish to default embed_credentials to false #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
Contributor
Author
|
hey @andrewnester |
andrewnester
reviewed
Dec 4, 2025
Contributor
andrewnester
left a comment
andrewnester
left a comment
There was a problem hiding this comment.
Minor comment regarding tests but overall looks good! @denik could you TAL as well?
Contributor
Author
|
@andrewnester pushed the changes, |
andrewnester
approved these changes
Dec 5, 2025
Collaborator
|
Commit: 5dbf42a
11 interesting tests: 7 KNOWN, 2 flaky, 2 SKIP
Top 31 slowest tests (at least 2 minutes):
|
auto-merge was automatically disabled
December 5, 2025 15:25
Head branch was pushed to by a user without write access
varundeepsaini
force-pushed
the
fix-lakeview-embed-credentials-default
branch
from
77a78a7 to
ec40595
Compare
varundeepsaini
force-pushed
the
fix-lakeview-embed-credentials-default
branch
from
ec40595 to
5dbf42a
Compare
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Contributor
Author
|
@andrewnester there was a test failing on windows, fixed it, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4001
Changes
Add override for
lakeview publishto explicitly sendembed_credentials: falsewhen--embed-credentialsflag is not provided.Why
The SDK omits
falseboolean values from JSON requests due toomitempty. This caused the API to default totrue, embedding credentials even when the flag wasn't set. The fix usesForceSendFieldsto always send the value explicitly.Tests
Added acceptance test verifying the request body contains
"embed_credentials": false.