-
Notifications
You must be signed in to change notification settings - Fork 5
Add §"Working with phylogenetic data" #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ms609
wants to merge
2
commits into
main
Choose a base branch
from
33-phylogenetic-data
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a ### heading? The table of contents near the top lists the first ## heading as follows:
Working with trees in R: packages dedicated to the handling, manipulation, and visualization of phylogenetic data
It seems to me that this new category would fall under that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, I wonder if the top heading should be changed to "Working with phylogenetic data in R", and then this new subcategory could be changed to e.g., "Working with other phylogenetic data in R"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good point; I usually use "phylogenetic data" to refer to the observations from which phylogenies are reconstructed, but in the ToC it is almost used as though the trees themselves are the phylogenetic data.
In my view the new content represents a step before reconstructing trees, so fits logically before tree reconstruction in the current structure. On this view, perhaps we ought to move the current "working with trees in R" section after "Building trees in R" (you can't work with trees if you haven't (re)constructed them yet!).
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, that makes a lot more sense. I could see this new category then remaining a separate category (the first category?), followed by the current second category and then the current first category? (perhaps with some editing of the ToC?)