-
Notifications
You must be signed in to change notification settings - Fork 5
Add §"Working with phylogenetic data" #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
A section to this effect is a useful addition and doesn't introduce much duplication. Before merging, it would be good if others could check that:
|
|
Should this include rphenoscape too? |
|
I'd say it seems to fit @hlapp |
Co-authored-by: William Gearty <willgearty@gmail.com>
| - `r github("Leonardini/treeCentrality")` can compute several statistics inspired from network science. | ||
|
|
||
|
|
||
| ## Working with phylogenetic data in R |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a ### heading? The table of contents near the top lists the first ## heading as follows:
Working with trees in R: packages dedicated to the handling, manipulation, and visualization of phylogenetic data
It seems to me that this new category would fall under that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, I wonder if the top heading should be changed to "Working with phylogenetic data in R", and then this new subcategory could be changed to e.g., "Working with other phylogenetic data in R"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, good point; I usually use "phylogenetic data" to refer to the observations from which phylogenies are reconstructed, but in the ToC it is almost used as though the trees themselves are the phylogenetic data.
In my view the new content represents a step before reconstructing trees, so fits logically before tree reconstruction in the current structure. On this view, perhaps we ought to move the current "working with trees in R" section after "Building trees in R" (you can't work with trees if you haven't (re)constructed them yet!).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, that makes a lot more sense. I could see this new category then remaining a separate category (the first category?), followed by the current second category and then the current first category? (perhaps with some editing of the ToC?)
List packages that handle phylogenetic data, incorporating suggestions from #33.
Closes #33.