Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@
use Rector\Set\ValueObject\LevelSetList;
use Rector\Set\ValueObject\SetList;
use Rector\Strict\Rector\Empty_\DisallowedEmptyRuleFixerRector;
use Rector\Strict\Rector\If_\BooleanInIfConditionRuleFixerRector;
use Rector\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector;
use Rector\TypeDeclaration\Rector\Property\TypedPropertyFromAssignsRector;
use Rector\ValueObject\PhpVersion;
Expand Down Expand Up @@ -161,7 +160,6 @@
$rectorConfig->rule(StringClassNameToClassConstantRector::class);
$rectorConfig->rule(PrivatizeFinalClassPropertyRector::class);
$rectorConfig->rule(CompleteDynamicPropertiesRector::class);
$rectorConfig->rule(BooleanInIfConditionRuleFixerRector::class);
$rectorConfig->rule(SingleInArrayToCompareRector::class);
$rectorConfig->rule(VersionCompareFuncCallToConstantRector::class);
$rectorConfig->rule(ExplicitBoolCompareRector::class);
Expand Down
4 changes: 2 additions & 2 deletions src/Config/Services.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@

namespace CodeIgniter\Tasks\Config;

use CodeIgniter\Config\BaseService;
use CodeIgniter\Tasks\CronExpression;
use CodeIgniter\Tasks\Scheduler;
use Config\Services as BaseServices;

class Services extends BaseServices
class Services extends BaseService
{
/**
* Returns the Task Scheduler
Expand Down
2 changes: 1 addition & 1 deletion src/RunResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,11 @@
*
* @param int|string $value
*/
protected function isInList($value, string $list): bool

Check warning on line 150 in src/RunResolver.php

View workflow job for this annotation

GitHub Actions / infection / Mutation Testing

Escaped Mutant for Mutator "ProtectedVisibility": @@ @@ * * @param int|string $value */ - protected function isInList($value, string $list): bool + private function isInList($value, string $list): bool { $list = explode(',', $list); return in_array(trim((string) $value), $list, true);
{
$list = explode(',', $list);

return in_array(trim($value), $list, true);
return in_array(trim((string) $value), $list, true);

Check warning on line 154 in src/RunResolver.php

View workflow job for this annotation

GitHub Actions / infection / Mutation Testing

Escaped Mutant for Mutator "UnwrapTrim": @@ @@ protected function isInList($value, string $list): bool { $list = explode(',', $list); - return in_array(trim((string) $value), $list, true); + return in_array((string) $value, $list, true); } /** * Determines if the $value is one of the increments.
}

/**
Expand Down
2 changes: 1 addition & 1 deletion src/Task.php
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ protected function buildName()
*/
public function __get(string $key)
{
if ($key === 'name' && empty($this->name)) {
if ($key === 'name' && (! isset($this->name) || ($this->name === ''))) {
return $this->buildName();
}

Expand Down
Loading