Skip to content

Conversation

@yassinedoghri
Copy link
Contributor

Description
Hi, I stumbled on this issue when using phpstan-codeigniter:
Internal error: Services factory class "CodeIgniter\Tasks\Config\Services" does not extend CodeIgniter\Config\BaseService.

Tasks services don't extend the right CodeIgniter\Config\BaseService class as they should.

This PR fixes it. Thank you!

@coveralls
Copy link

coveralls commented Nov 22, 2025

Pull Request Test Coverage Report for Build 19601730262

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.252%

Totals Coverage Status
Change from base Build 17488281517: 0.0%
Covered Lines: 367
Relevant Lines: 469

💛 - Coveralls

@michalsn
Copy link
Member

Thank you.

Can you remove the rule: BooleanInIfConditionRuleFixerRector from rector.php and then run composer cs-fix?

@yassinedoghri
Copy link
Contributor Author

Done! Also fixed some rector issues along the way. Thank you for the review.

@michalsn
Copy link
Member

I'm a bit lost with this Rector error.
@samsonasik, if you have a moment, could you take a look?

@samsonasik
Copy link
Member

That seems due to DeclareStrictTypesTestsRector for no-namespace tests file, should be resolved at PR:

You can skip it for now while wait for next release, add this under: skip() config in rector.php

\Rector\PHPUnit\CodeQuality\Rector\StmtsAwareInterface\DeclareStrictTypesTestsRector::class,

@michalsn
Copy link
Member

Awesome. Thank you @samsonasik!

@michalsn michalsn merged commit 63f68a8 into codeigniter4:develop Nov 23, 2025
32 of 33 checks passed
@michalsn
Copy link
Member

Thank you @yassinedoghri

@michalsn michalsn mentioned this pull request Nov 23, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants