Skip to content

Conversation

@tdinunzio-trayport
Copy link
Contributor

what

Add support for DocumentDB serverless clusters

  • new module variable
  • updated dependencies to releases supporting serverless
  • added new example and test for serverless

why

Serverless instance support have been added to documentdb, as well as in the aws terraform provider. This PR makes it configurable via this module.

references

https://aws.amazon.com/about-aws/whats-new/2025/07/amazon-documentdb-serverless/
https://github.com/hashicorp/terraform-provider-aws/releases/tag/v6.8.0
https://github.com/aws/aws-sdk-go-v2/blob/release-2025-07-30/service/docdb/CHANGELOG.md#v1430-2025-07-30

@tdinunzio-trayport tdinunzio-trayport requested review from a team as code owners August 14, 2025 11:50
@mergify mergify bot added the triage Needs triage label Aug 14, 2025
@mergify
Copy link

mergify bot commented Aug 14, 2025

Important

Cloud Posse Engineering Team Review Required

This pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes.

To expedite this process, reach out to us on Slack in the #pr-reviews channel.

@mergify mergify bot added the needs-cloudposse Needs Cloud Posse assistance label Aug 14, 2025
@phene
Copy link

phene commented Aug 15, 2025

Excellent -- I was just getting ready to contribute this myself!

@Benbentwo
Copy link
Member

/terratest

@Benbentwo Benbentwo added the major Breaking changes (or first stable release) label Sep 5, 2025
@Benbentwo
Copy link
Member

Overall, this looks good. We just need to fix the test and the variable validation then I'll approve it and we can get this merged in.

@tdinunzio-trayport
Copy link
Contributor Author

Thank you very much for the review. Just pushed a couple of commits that should hopefully make the tests pass.

@Benbentwo
Copy link
Member

/terratest

@Benbentwo Benbentwo closed this Sep 5, 2025
@Benbentwo Benbentwo reopened this Sep 5, 2025
@Benbentwo
Copy link
Member

/terratest

@Benbentwo
Copy link
Member

(Ignore that closing of PR - accidently clicked wrong button 😬 )

@Benbentwo
Copy link
Member

Looks like a formatting issue and then we should be good to go.

@tdinunzio-trayport
Copy link
Contributor Author

Sorry for this one, just pushed a fix

@Benbentwo
Copy link
Member

/terratest

Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the minimum version of AWS is a little concerning since we've had issues in the past with v6, but we need to proceed and update anyways. With the v6 aws provider this thus becomes a major release 🚀

@Benbentwo Benbentwo merged commit 6de2235 into cloudposse:main Sep 12, 2025
16 checks passed
@mergify mergify bot removed needs-cloudposse Needs Cloud Posse assistance triage Needs triage labels Sep 12, 2025
@github-actions
Copy link

These changes were released in v1.0.0.

@tdinunzio-trayport
Copy link
Contributor Author

Excellent news! Thank you for the review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major Breaking changes (or first stable release)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants