-
-
Notifications
You must be signed in to change notification settings - Fork 99
Serverless support #132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serverless support #132
Conversation
|
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
be5ec4c to
e59623b
Compare
|
Excellent -- I was just getting ready to contribute this myself! |
|
/terratest |
|
Overall, this looks good. We just need to fix the test and the variable validation then I'll approve it and we can get this merged in. |
|
Thank you very much for the review. Just pushed a couple of commits that should hopefully make the tests pass. |
|
/terratest |
|
/terratest |
|
(Ignore that closing of PR - accidently clicked wrong button 😬 ) |
|
Looks like a formatting issue and then we should be good to go. |
|
Sorry for this one, just pushed a fix |
|
/terratest |
Benbentwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the minimum version of AWS is a little concerning since we've had issues in the past with v6, but we need to proceed and update anyways. With the v6 aws provider this thus becomes a major release 🚀
|
These changes were released in v1.0.0. |
|
Excellent news! Thank you for the review and merge! |
what
Add support for DocumentDB serverless clusters
why
Serverless instance support have been added to documentdb, as well as in the aws terraform provider. This PR makes it configurable via this module.
references
https://aws.amazon.com/about-aws/whats-new/2025/07/amazon-documentdb-serverless/
https://github.com/hashicorp/terraform-provider-aws/releases/tag/v6.8.0
https://github.com/aws/aws-sdk-go-v2/blob/release-2025-07-30/service/docdb/CHANGELOG.md#v1430-2025-07-30