initial proposed changes to Ep2 - Basics #29

theabro · 2024-11-15T13:22:34Z

These are some initial suggestions for content for Episode 2 - Basics, primarily using the EPCC course as inspiration but simplifying things somewhat.

github-actions · 2024-11-15T13:22:49Z

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

🎯 correct output
🖼️ correct figures
❓ new warnings
‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/intro-to-modern-fortran/compare/md-outputs..md-outputs-PR-29

The following changes were observed in the rendered markdown documents:

 02-variables.md (new)  | 482 +++++++++++++++++++++++++++++++++++++++
 03-maths.md (new)      | 608 +++++++++++++++++++++++++++++++++++++++++++++++++
 04-logic.md (new)      | 101 ++++++++
 05-strings.md (new)    |  26 +++
 config.yaml            |   6 +-
 data/exercises.tar.gz  | Bin 359 -> 5817 bytes
 discuss.md (new)       |  20 ++
 introduction.md (gone) | 220 ------------------
 md5sum.txt             |   8 +-
 9 files changed, 1247 insertions(+), 224 deletions(-)

What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2025-05-19 09:20:21 +0000

episodes/02-basics.Rmd

warrickball · 2024-11-16T21:07:59Z

episodes/02-basics.Rmd

+program example3
+   implicit none
+
+   real, parameter :: pi = 3.14159265
+
+end program example3


I personally think it would be useful to either expand this example to show the (compile-time) failure if you try to modify pi or leave this is an exercise so users can cause the error themselves.

Good point - I'll work on this.

episodes/02-basics.Rmd

Co-authored-by: Warrick Ball <warrickball@gmail.com>

theabro · 2024-12-02T16:21:40Z

I've now added the example error when trying to alter a parameter

Co-authored-by: Warrick Ball <warrickball@gmail.com>

…a solutions directory.

…all challenges have names

… exercises dir with the correct sub dir names

…k of) for parameter kind conversion

jklebes

I tested building this as local webpage. I didn't test downloading the exercises or running the code examples.
Things were a bit confusing because of file 02-basiscs.Rmd, which is not displayed online and contains duplicate material. I made some duplicate comments. It looks like migration of content from Basics file to other files is unfinished, e.g. 05-strings is empty with the content in basics.
The content itself seems good and complete, with the minor comments. The formatting and writing is good.
I would finish the migration from 02-Basics and then merge PR, to change other details later.

jklebes · 2025-09-11T12:05:13Z

exercises/02-variables/README.md

+
+1. Make sure your code conforms to the style
+followed by this course.
+2. Add Ford comments to document the program


Has never been introduced

jklebes · 2025-09-11T12:13:51Z

exercises/02-variables/solutions/variables.f90

+
+    number_of_pelicans          = 5
+    pelican_weight              = 2.5              ! kg
+    pelican_population_dynamics = (-1.2e3, 0.9e2)  ! births, deaths per year


Unusual use of a complex number , maybe it's better to have no complex example here

jklebes · 2025-09-11T12:23:24Z

episodes/02-basics.Rmd

+
+| Relation                 | Operator | Older form | For              |
+|--------------------------|----------|------------|------------------|
+| Less than                | `< `     | `.lt.`     | `integer` `real` |


put commas in these lists in table

jklebes · 2025-09-11T12:27:31Z

episodes/02-basics.Rmd

+Equivalence between two logical expressions or variables is established
+via the logical operators `.eqv.` and `.neqv.`. 
+
+While some some compilers may allow the use of `==`, this should be avoided.


"to compare logical expression" - restate to be extra clear that this applies to logical and "==" should not be avoided in general.

jklebes · 2025-09-11T12:54:16Z

episodes/02-basics.Rmd

+ T
+```
+
+## Character variables


Draft content to be moved to file 05-strings ?

jklebes · 2025-09-11T12:59:39Z

episodes/02-variables.md

+
+:::
+
+::: caution


I think the big red warning box is a bit too attention-grabbing for this non-essential warning

jklebes · 2025-09-11T13:00:36Z

episodes/02-variables.md

+
+1. Make sure your code conforms to the style
+followed by this course.
+2. Add Ford comments to document the program


Has not been introduced

jklebes · 2025-09-11T13:01:46Z

episodes/04-logic.md

+Equivalence between two logical expressions or variables is established
+via the logical operators `.eqv.` and `.neqv.`. 
+
+While some some compilers may allow the use of `==`, this should be avoided.


"when comparing logicals." , being explicit

jklebes · 2025-09-11T13:06:07Z

episodes/03-maths.md

+```fortran
+! This goes after the program statement
+! We will cover modules in a later episode
+use, intrinsic :: iso_fortran_env, only: r_32 => real32, r_64 => real64


Should we just use the default names real32 to keep this use statement simple in number of new syntax/concepts to understand (and fitting on a line when displayed in browser)

jklebes · 2025-09-11T13:13:16Z

episodes/04-logic.md

+
+:::::::::::::::::::::::::::::::::::::::: keypoints
+
+- Th


theabro added 2 commits October 31, 2024 14:44

initial commit covering Fortran data types

6402f32

Merge branch 'carpentries-incubator:main' into ep2_basics

d7c4024

github-actions bot pushed a commit that referenced this pull request Nov 15, 2024

differences for PR #29

907e99f

theabro mentioned this pull request Nov 15, 2024

Episode 2: Basics #12

Open

warrickball reviewed Nov 16, 2024

View reviewed changes

episodes/02-basics.Rmd Outdated Show resolved Hide resolved

warrickball reviewed Nov 16, 2024

View reviewed changes

episodes/02-basics.Rmd Outdated Show resolved Hide resolved

theabro and others added 2 commits November 20, 2024 10:32

Update episodes/02-basics.Rmd

3744b87

Co-authored-by: Warrick Ball <warrickball@gmail.com>

Update episodes/02-basics.Rmd

900449f

Co-authored-by: Warrick Ball <warrickball@gmail.com>

github-actions bot pushed a commit that referenced this pull request Nov 20, 2024

differences for PR #29

d1721e3

added error message when trying to alter a parameter

fcb2bf3

github-actions bot pushed a commit that referenced this pull request Dec 2, 2024

differences for PR #29

c49d0bf

astroDimitrios marked this pull request as draft March 17, 2025 15:41

theabro and others added 4 commits April 17, 2025 16:38

initial commit covering Fortran data types

e20bcb7

Update episodes/02-basics.Rmd

abdb0ab

Co-authored-by: Warrick Ball <warrickball@gmail.com>

Update episodes/02-basics.Rmd

0af6e5c

Co-authored-by: Warrick Ball <warrickball@gmail.com>

added error message when trying to alter a parameter

bef7877

astroDimitrios force-pushed the ep2_basics branch from fcb2bf3 to bef7877 Compare April 17, 2025 15:40

github-actions bot pushed a commit that referenced this pull request Apr 17, 2025

differences for PR #29

cdc9ea7

Splits off the start of the variables lesson into its own file - add …

826f669

…a solutions directory.

github-actions bot pushed a commit that referenced this pull request Apr 23, 2025

differences for PR #29

5a45594

Further split up the basics section - adds in the section on Maths

eabc28b

github-actions bot pushed a commit that referenced this pull request Apr 25, 2025

differences for PR #29

2296307

astroDimitrios added 4 commits April 25, 2025 15:12

Remove whitespace

2e2cf0b

Line highlighting

80b7006

Ignore executables

c2a2b9d

Alter the exercises directory structure

43efde7

github-actions bot pushed a commit that referenced this pull request Apr 25, 2025

differences for PR #29

b0b7504

astroDimitrios added 4 commits April 25, 2025 16:00

Tidy variables.f90 code

cb8301e

Add challenges to the exercises directory for the variables section

67ae508

Add challenges to the README for the basic maths section - make sure …

e92d238

…all challenges have names

Undo line highlighting attempt

0539a7f

github-actions bot pushed a commit that referenced this pull request Apr 25, 2025

differences for PR #29

674b185

Undo compiler flag testing with ljp code

a142006

github-actions bot pushed a commit that referenced this pull request Apr 25, 2025

differences for PR #29

22b77fb

Add key points to the maths section

92d0685

github-actions bot pushed a commit that referenced this pull request Apr 25, 2025

differences for PR #29

7de1f55

astroDimitrios added 2 commits April 25, 2025 16:58

Add in messages for where challenges should be written and update the…

8940443

… exercises dir with the correct sub dir names

Fix config

36c7a98

github-actions bot pushed a commit that referenced this pull request Apr 25, 2025

differences for PR #29

b3a8dc6

astroDimitrios added 4 commits April 29, 2025 10:42

Clarify type/kind and add explanation of the gfortran warning (or lac…

e285d81

…k of) for parameter kind conversion

Update AU unit

da2c2dd

Update more units AU

f9385d8

Add example of scientific notation

604db39

github-actions bot pushed a commit that referenced this pull request Apr 29, 2025

differences for PR #29

abf355a

Merge remote-tracking branch 'origin/ep2_basics' into ep2_basics

6e64c87

github-actions bot pushed a commit that referenced this pull request May 19, 2025

differences for PR #29

04303e3

jklebes marked this pull request as ready for review September 11, 2025 12:03

jklebes requested changes Sep 11, 2025

View reviewed changes


		:::

		::: caution


		:::::::::::::::::::::::::::::::::::::::: keypoints

		- Th

Uh oh!

initial proposed changes to Ep2 - Basics #29

Are you sure you want to change the base?

initial proposed changes to Ep2 - Basics #29

Uh oh!

Conversation

theabro commented Nov 15, 2024

Uh oh!

github-actions bot commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thank you!

Rendered Changes

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

theabro commented Dec 2, 2024

Uh oh!

jklebes left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Nov 15, 2024 •

edited

Loading