Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/aws-durable-execution-sdk-js/src/types/logger.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
* Provides structured logging capabilities for durable execution contexts
*/
export interface Logger {
/** Generic log method with configurable level */
log(level: string, message?: string, data?: unknown, error?: Error): void;
/** Generic log method with configurable level (optional for compatibility with popular loggers) */
log?(level: string, message?: string, data?: unknown, error?: Error): void;
/** Log error messages with optional error object and additional data */
error(message?: string, error?: Error, data?: unknown): void;
/** Log warning messages with optional additional data */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ describe("Context Logger", () => {
const logger = factory("generic-step");
const testError = new Error("generic error");

logger.log("custom", "custom message", { custom: "data" }, testError);
logger.log?.("custom", "custom message", { custom: "data" }, testError);

expect(mockBaseLogger.log).toHaveBeenCalledWith(
"custom",
Expand Down Expand Up @@ -173,7 +173,7 @@ describe("Context Logger", () => {
const logger = factory("test-step");

// Test all logger methods to ensure coverage
logger.log(
logger.log?.(
"custom",
"log message",
{ data: "test" },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,19 +36,21 @@ export const createContextLoggerFactory = (
};

return {
log: (
level: string,
message?: string,
data?: unknown,
error?: Error,
): void => {
baseLogger.log(
level,
message,
createLogEntry(level, message, data, error),
error,
);
},
log: baseLogger.log
? (
level: string,
message?: string,
data?: unknown,
error?: Error,
): void => {
baseLogger.log!(
level,
message,
createLogEntry(level, message, data, error),
error,
);
}
: undefined,
info: (message?: string, data?: unknown): void => {
baseLogger.info(message, createLogEntry("info", message, data));
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe("Default Logger", () => {
const testData = { key: "value" };
const testError = new Error("test error");

logger.log("custom", "test message", testData, testError);
logger.log?.("custom", "test message", testData, testError);

expect(consoleSpy).toHaveBeenCalledWith(
"custom",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ describe("Mode-Aware Logger", () => {
false,
);

logger.log("custom", "log message", { data: "test" }, new Error("test"));
logger.log?.("custom", "log message", { data: "test" }, new Error("test"));
logger.error("error message", new Error("test"), { data: "test" });
logger.warn("warn message", { data: "test" });
logger.debug("debug message", { data: "test" });
Expand Down Expand Up @@ -131,7 +131,7 @@ describe("Mode-Aware Logger", () => {
true,
);

logger.log("custom", "log message");
logger.log?.("custom", "log message");
logger.error("error message", new Error("test"));
logger.warn("warn message");
logger.debug("debug message");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@ export const createModeAwareLogger = (
durableExecutionMode === DurableExecutionMode.ExecutionMode;

return {
log: (
level: string,
message?: string,
data?: unknown,
error?: Error,
): void => {
if (shouldLog()) enrichedLogger.log(level, message, data, error);
},
log: enrichedLogger.log
? (
level: string,
message?: string,
data?: unknown,
error?: Error,
): void => {
if (shouldLog()) enrichedLogger.log!(level, message, data, error);
}
: undefined,
info: (message?: string, data?: unknown): void => {
if (shouldLog()) enrichedLogger.info(message, data);
},
Expand Down
Loading