feat(sdk): make Logger.log() method optional for external logger compatibility #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atibility Make the log() method optional in the Logger interface to enable compatibility with popular TypeScript logging libraries like AWS Powertools Logger, Pino, and Winston, which don't implement a generic log() method. Changes: - Made Logger.log() optional in interface definition - Updated context-logger to conditionally create log method - Updated mode-aware-logger to handle optional log method - Fixed all tests to use optional chaining for log() calls - Added LOGGER_COMPATIBILITY.md with usage examples This is a non-breaking change that maintains backward compatibility with existing custom loggers while enabling easier integration with external logging libraries.
anthonyting
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the log() method optional in the Logger interface to enable compatibility with popular TypeScript logging libraries like AWS Powertools Logger, Pino, and Winston, which don't implement a generic log() method.
Changes:
This is a non-breaking change that maintains backward compatibility with existing custom loggers while enabling easier integration with external logging libraries.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.