Skip to content

Allow calling internal methods also as notifications #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 1 commit into from
Dec 2, 2025
Merged

Allow calling internal methods also as notifications #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/msgpackrouter/router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,13 @@ func (r *Router) connectionLoop(conn io.ReadWriteCloser) {
// This handler is called when a notification is received from the client
slog.Debug("Received notification", "method", method, "params", params)

// Check if the method is an internal method
if handler, ok := r.routesInternal[method]; ok {
// call the internal method handler (since it's a notification, discard the result)
_, _ = handler(context.Background(), msgpackconn, params)
return
}

// Check if the method is registered
client, ok := r.getConnectionForMethod(method)
if !ok {
Expand Down