Skip to content

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Nov 28, 2025

Motivation

This is mainly required to allow sending messages to the monitor (mon/write) using a notification instead of a request. This change should increase the throughput of this debug channel.

Change description

The router's internal methods, expect $/register and $/reset, can now be invoked either as Request or as Notification.
If a client opts to use the Notification:

  • It will lose the return/error values.
  • It will not know when the action has been completed (the notification returns immediately, while a request will wait until the action completes).

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@cmaglie cmaglie self-assigned this Nov 28, 2025
@cmaglie cmaglie added the enhancement New feature or request label Nov 28, 2025
@cmaglie cmaglie requested review from a team and eigen-value November 28, 2025 15:07
Copy link
Collaborator

@eigen-value eigen-value left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmaglie cmaglie merged commit 8cfea03 into main Dec 2, 2025
8 checks passed
@cmaglie cmaglie deleted the monitor-write-as-notification branch December 2, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants