Skip to content

Update the iosxr_banner module to allow exec banner configuration on IOS-XR devices #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
nbeard49 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Update the iosxr_banner module to allow exec banner configuration on IOS-XR devices #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14b5b4d
Update the banner module to allow exec banner configuration on IOS-XR
nbeard49 Mar 11, 2025
0341c90
Documenation update to reference 'exec' banner
nbeard49 Mar 12, 2025
3f4c021
Merge remote-tracking branch 'upstream/main'
nbeard49 Mar 12, 2025
14ad825
chore: auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Mar 12, 2025
870e3fb
test
nbeard49 Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/modules/iosxr_banner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ def run(self):
def main():
"""main entry point for module execution"""
argument_spec = dict(
banner=dict(required=True, choices=["login", "motd"]),
banner=dict(required=True, choices=["login", "motd", "exec"]),
Copy link
Member

@Ruchip16 Ruchip16 Apr 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes here done, how are you validating those?
also we need to do changes in rm_templates, argspec files as well and not just here as it is just a doc file, actual changes need to be implemented in argspec, rm_templates file

text=dict(),
state=dict(default="present", choices=["present", "absent"]),
)
Expand Down
1 change: 1 addition & 0 deletions tests/unit/modules/network/iosxr/fixtures/iosxr_banner_config.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
banner motd this is my motd banner
banner login this is my login banner
banner exec this is my exec banner
14 changes: 12 additions & 2 deletions tests/unit/modules/network/iosxr/test_iosxr_banner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,15 @@ def test_iosxr_banner_fail_create(self):
result = self.execute_module(failed=True, changed=True)
self.assertEqual(
result["msg"],
"value of banner must be one of: login, motd, got: exec1",
"value of banner must be one of: login, motd, exec got: exec1",
)

def test_iosxr_banner_exec1_fail_remove(self):
set_module_args(dict(banner="exec1", state="absent"))
result = self.execute_module(failed=True, changed=True)
self.assertIn(
result["msg"],
"value of banner must be one of: login, motd, got: exec1",
"value of banner must be one of: login, motd, exec got: exec1",
)

def test_iosxr_banner_motd_create(self):
Expand All @@ -114,3 +114,13 @@ def test_iosxr_banner_motd_remove(self):
set_module_args(dict(banner="motd", state="absent"))
commands = ["no banner motd"]
self.execute_module(changed=True, commands=commands)

def test_iosxr_banner_exec_create(self):
set_module_args(dict(banner="exec", text="test\nbanner\nstring"))
commands = ["banner exec test\nbanner\nstring"]
self.execute_module(changed=True, commands=commands)

def test_iosxr_banner_exec_remove(self):
set_module_args(dict(banner="exec", state="absent"))
commands = ["no banner exec"]
self.execute_module(changed=True, commands=commands)