Update the iosxr_banner module to allow exec banner configuration on IOS-XR devices #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@nbeard49 kindly add the change log , unit and integration test to confirm |
Ruchip16
reviewed
Apr 4, 2025
| """main entry point for module execution""" | ||
| argument_spec = dict( | ||
| banner=dict(required=True, choices=["login", "motd"]), | ||
| banner=dict(required=True, choices=["login", "motd", "exec"]), |
Member
There was a problem hiding this comment.
the changes here done, how are you validating those?
also we need to do changes in rm_templates, argspec files as well and not just here as it is just a doc file, actual changes need to be implemented in argspec, rm_templates file
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Update the iosxr_banner module to allow exec banner configuration on IOS-XR devices
ISSUE TYPE
COMPONENT NAME
iosxr_banner
ADDITIONAL INFORMATION
It appears that updating the array in the choices function to include the 'exec' string allows this to work as expected. The 'exec' option can then be passed to the banner parameter in the module without issue. This has been tested locally against ASR9K/NCS routers.