-
Notifications
You must be signed in to change notification settings - Fork 188
[TASK] Improve "Create a root page" chapter #721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
releases: main, 13.4
Member
Author
mabolek
suggested changes
Apr 26, 2025
Contributor
mabolek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement! I improved on the greatness and corrected some things too. 😃
Co-authored-by: Mathias Bolt Lesniak <git@mabolek.dev>
Co-authored-by: Mathias Bolt Lesniak <git@mabolek.dev>
mabolek
approved these changes
Apr 26, 2025
Contributor
|
The backport to stderrstdoutTo backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-13.4 13.4
# Navigate to the new working tree
cd .worktrees/backport-13.4
# Create a new branch
git switch --create backport-721-to-13.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick b4cbe218d16f3ad6c3d0ac2775dab42df54f4413,eb41d03d34959c4f6881fbc10834192aecd55bda,21e4ac4d27047a3e956cabab21865c32ebf3d5a5
# Push it to GitHub
git push --set-upstream origin backport-721-to-13.4
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-13.4Then, create a pull request where the |
linawolf
added a commit
that referenced
this pull request
Apr 26, 2025
* [TASK] Improve "Create a root page" chapter releases: main, 13.4 * Apply suggestions from code review Co-authored-by: Mathias Bolt Lesniak <git@mabolek.dev> * Update Documentation/FirstProject/CreateRootPage.rst Co-authored-by: Mathias Bolt Lesniak <git@mabolek.dev> --------- Co-authored-by: Mathias Bolt Lesniak <git@mabolek.dev> (cherry picked from commit 80a1ebe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releases: main, 13.4