Skip to content

fix: improve error messaging when uploading blueprints #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release53
Choose a base branch
from
Open

fix: improve error messaging when uploading blueprints #1568

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion meteor/server/api/blueprints/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ import { DBStudio } from '@sofie-automation/corelib/dist/dataModel/Studio'
import { UserPermissions } from '@sofie-automation/meteor-lib/dist/userPermissions'
import { assertConnectionHasOneOfPermissions, RequestCredentials } from '../../security/auth'
import { blueprintsPerformDevelopmentMode } from './development'
import { stringifyError } from '@sofie-automation/shared-lib/dist/lib/stringifyError'

const PERMISSIONS_FOR_MANAGE_BLUEPRINTS: Array<keyof UserPermissions> = ['configure']

Expand Down Expand Up @@ -170,7 +171,9 @@ async function innerUploadBlueprint(
let blueprintManifest: SomeBlueprintManifest | undefined
try {
blueprintManifest = evalBlueprint(newBlueprint)
} catch (_e) {
} catch (e) {
logger.error(`Error evaluating Blueprint "${blueprintId}": "${stringifyError(e)}"`)

throw new Meteor.Error(400, `Blueprint ${blueprintId} failed to parse`)
Copy link
Contributor

@rjmunro rjmunro Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put more information in the request response here as well? That way I can see it straight away when I run yarn build-sync-local on my blueprints - I don't have to go hunting in server log files somewhere.

I did try this when I had a bad blueprint upload to diagnose, but didn't get around to making a PR:

release53...rjmunro/improve-blueprint-upload-errors

}

Expand Down
Loading