fix: improve error messaging when uploading blueprints #1568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
rjmunro
reviewed
Dec 2, 2025
| } catch (e) { | ||
| logger.error(`Error evaluating Blueprint "${blueprintId}": "${stringifyError(e)}"`) | ||
|
|
||
| throw new Meteor.Error(400, `Blueprint ${blueprintId} failed to parse`) |
Contributor
There was a problem hiding this comment.
Can we put more information in the request response here as well? That way I can see it straight away when I run yarn build-sync-local on my blueprints - I don't have to go hunting in server log files somewhere.
I did try this when I had a bad blueprint upload to diagnose, but didn't get around to making a PR:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #1512
About the Contributor
This pull request is posted on behalf of Superfly
Type of Contribution
This is a: Code improvement
Current Behavior
When uploading a blueprint fails with a parsing error, the actual error isnt logged, making it hard to figure out what the problem is
New Behavior
This error is now logged
Testing
Affected areas
Time Frame
Other Information
Status