Use minimum API version for bulk operations #6697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2025
Contributor
Author
3 tasks
Contributor
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
Contributor
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3553 tests passing in 1415 suites. Report generated by 🧪jest coverage report action from a96993e |
nickwesselman
changed the title
packages/app/src/cli/services/bulk-operations/bulk-operation-status.test.ts
Outdated
Show resolved
Hide resolved
jordanverasamy
approved these changes
Dec 9, 2025
Contributor
jordanverasamy
left a comment
jordanverasamy
left a comment
There was a problem hiding this comment.
thank you for putting this together <3
nickwesselman
force-pushed
the
poll_bulk_operations_faster
branch
from
a694179 to
d894b0c
Compare
nickwesselman
force-pushed
the
bulk_operation_error_message
branch
from
0fbeaaa to
687de29
Compare
Contributor
Author
|
/snapit |
ericlee878
reviewed
Dec 9, 2025
packages/app/src/cli/services/bulk-operations/execute-bulk-operation.test.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/snapit |
2 similar comments
Contributor
|
/snapit |
Contributor
|
/snapit |
nickwesselman
force-pushed
the
poll_bulk_operations_faster
branch
from
d894b0c to
544183d
Compare
nickwesselman
force-pushed
the
bulk_operation_error_message
branch
from
847e0d3 to
8cffe52
Compare
nickwesselman
force-pushed
the
poll_bulk_operations_faster
branch
from
544183d to
9d4706e
Compare
nickwesselman
force-pushed
the
bulk_operation_error_message
branch
from
8cffe52 to
28408ea
Compare
3 tasks
Contributor
|
/snapit |
Contributor
|
/snapit |
gonzaloriestra
approved these changes
Dec 12, 2025
nickwesselman
force-pushed
the
bulk_operation_error_message
branch
from
28408ea to
d3c6bcf
Compare
3 tasks
nickwesselman
force-pushed
the
bulk_operation_error_message
branch
from
29170fd to
b7caf67
Compare
Contributor
Author
|
/snapit |
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/api/admin.d.ts@@ -41,6 +41,14 @@ export declare function adminRequestDoc<TResult, TVariables extends Variables>(o
* @returns - An array of supported API versions.
*/
export declare function supportedApiVersions(session: AdminSession, preferredBehaviour?: RequestModeInput): Promise<string[]>;
+/**
+ * GraphQL query to retrieve all API versions.
+ *
+ * @param session - Shopify admin session including token and Store FQDN.
+ * @param preferredBehaviour - Custom request behaviour for retries and timeouts.
+ * @returns - An array of supported and unsupported API versions.
+ */
+export declare function fetchApiVersions(session: AdminSession, preferredBehaviour?: RequestModeInput): Promise<ApiVersion[]>;
/**
* Returns the Admin API URL for the given store and version.
*
@@ -50,6 +58,10 @@ export declare function supportedApiVersions(session: AdminSession, preferredBeh
* @returns - Admin API URL.
*/
export declare function adminUrl(store: string, version: string | undefined, session?: AdminSession): string;
+interface ApiVersion {
+ handle: string;
+ supported: boolean;
+}
/**
* Executes a REST request against the Admin API.
*
@@ -82,4 +94,5 @@ export interface RestResponse {
headers: {
[key: string]: string[];
};
-}
\ No newline at end of file
+}
+export {};
\ No newline at end of file
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
This PR improves API version handling and error presentation in bulk operations to provide a more consistent and user-friendly experience.
WHAT is this pull request doing?
renderWarningtorenderErrorto better reflect severityresolveApiVersionfunction that intelligently selects the appropriate API version based on:How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
Checklist