Skip to content

Improve status messages for app bulk execute task #6692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nickwesselman merged 5 commits into from
Dec 10, 2025
Merged

Improve status messages for app bulk execute task #6692

nickwesselman merged 5 commits into from
Dec 10, 2025

Conversation

@nickwesselman
Copy link
Contributor

@nickwesselman nickwesselman commented Dec 6, 2025 •
edited
Loading

WHY are these changes introduced?

To improve the formatting of app bulk execute status messaging when --watch is used.

WHAT is this pull request doing?

  • Adds the type field to all bulk operation GraphQL queries and mutations
  • Updates the generated TypeScript types to include the new BulkOperationType enum
  • Improves the bulk operation status formatting to differentiate between query and mutation operations
  • Updates status messages to be more specific about whether objects are being read (for queries) or written (for mutations)

How to test your changes?

  1. Run a bulk operation query and verify that the type field is returned
  2. Run a bulk operation mutation and verify that the type field is returned
  3. Check that the status messages correctly show "objects read" for queries and "objects written" for mutations
  4. Verify that all tests pass with the updated formatting

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

@nickwesselman Graphite App
Copy link
Contributor Author

nickwesselman commented Dec 6, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nickwesselman nickwesselman mentioned this pull request Dec 6, 2025
Merged
3 tasks
@nickwesselman nickwesselman marked this pull request as ready for review December 6, 2025 01:07
@nickwesselman nickwesselman requested a review from a team as a code owner December 6, 2025 01:07
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

Caution

DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

@nickwesselman Graphite App
Copy link
Contributor Author

nickwesselman commented Dec 6, 2025

Part of https://github.com/shop/issues-api-foundations/issues/1149

This was referenced Dec 6, 2025
Merged
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🟡 Statements
79.2% (-0.03% 🔻)
 13903/17555
🟡 Branches
73.18% (+0.08% 🔼)
 6793/9282
🟡 Functions
79.33% (-0.04% 🔻)
 3562/4490
🟡 Lines
79.55% (-0.03% 🔻)
 13134/16510
Show new covered files 🐣
St.❔
 File Statements Branches Functions Lines
🟢
... / admin-as-app.ts
 100% 100% 100% 100%
🟢
... / bulk-operation-run-mutation.ts
 100% 100% 100% 100%
🟢
... / bulk-operation-run-query.ts
 100% 100% 100% 100%
🟢
... / get-bulk-operation-by-id.ts
 100% 100% 100% 100%
🟢
... / list-bulk-operations.ts
 100% 100% 100% 100%
🟢
... / staged-uploads-create.ts
 100% 100% 100% 100%
🔴
... / execute.ts
 0% 0% 0% 0%
🔴
... / status.ts
 0% 0% 0% 0%
🔴
... / pull.ts
 0% 100% 0% 0%
🟢
... / execute-operation.ts
 92.86% 83.33% 100% 92.31%
🔴
... / pull.ts
 0% 0% 0% 0%
🟢
... / bulk-operation-status.ts
 96% 90.63% 100% 100%
🟢
... / download-bulk-operation-results.ts
 100% 100% 100% 100%
🟢
... / execute-bulk-operation.ts
 92.98% 86.84% 100% 92.73%
🟢
... / format-bulk-operation-status.ts
 100% 100% 100% 100%
🟢
... / run-mutation.ts
 100% 100% 100% 100%
🟢
... / run-query.ts
 100% 100% 100% 100%
🟡
... / stage-file.ts
 72.73% 62.5% 83.33% 71.88%
🟢
... / watch-bulk-operation.ts
 100% 100% 100% 100%
🟢
... / common.ts
 95.24% 90% 100% 94.12%
🟢
... / execute-command-helpers.ts
 100% 100% 100% 100%
🔴
... / promiseWithResolvers.ts
 33.33% 50% 50% 33.33%
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴
... / execute.ts
 0%
0% (-100% 🔻)
 0% 0%
🟢
... / extension-instance.ts
84.8% (+0.23% 🔼)
77.6% (-0.91% 🔻)
92.06% (+0.13% 🔼)
85.11% (+0.24% 🔼)
🟡
... / specification.ts
 69.09%
75.61% (+2.44% 🔼)
76.47% (-1.31% 🔻)
 68.75%
🟢
... / ui_extension.ts
85.38% (-9.44% 🔻)
72.34% (-8.91% 🔻)
84% (-16% 🔻)
88% (-8.46% 🔻)
🟢
... / developer-platform-client.ts
84.62% (-1.5% 🔻)
73.68% (+3.1% 🔼)
81.82% (+1.82% 🔼)
90.63% (-2.71% 🔻)
🟢
... / api.ts
87.07% (-0.43% 🔻)
76.71% (-0.1% 🔻)
 100%
86.49% (-0.43% 🔻)
🟢
... / SingleTask.tsx
84.21% (-15.79% 🔻)
50% (-50% 🔻)
80% (-20% 🔻)
84.21% (-15.79% 🔻)
🔴
... / ui.tsx
50.82% (-0.79% 🔻)
42.86% (-5.53% 🔻)
54.55% (+1.42% 🔼)
50% (-0.82% 🔻)
🟢
... / console.ts
81.82% (+15.15% 🔼)
75% (-25% 🔻)
100% (+33.33% 🔼)
81.82% (+15.15% 🔼)
🔴
... / dev.ts
14.29% (+0.95% 🔼)
3.13% (+0.18% 🔼)
50% (-7.14% 🔻)
14.29% (+0.95% 🔼)
🟢
... / init.ts
88% (-0.89% 🔻)
71.43% (+4.76% 🔼)
86.67% (+4.85% 🔼)
88% (-0.89% 🔻)
🟢
... / storefront-renderer.ts
90.2% (-0.54% 🔻)
 78.95%
81.82% (-1.52% 🔻)
90.2% (-0.54% 🔻)
🟡
... / theme-polling.ts
67.12% (-0.93% 🔻)
 68.75% 78.57%
66.67% (-0.98% 🔻)

Test suite run success

3485 tests passing in 1406 suites.

Report generated by 🧪jest coverage report action from aa765ca

@nickwesselman nickwesselman mentioned this pull request Dec 8, 2025
Merged
3 tasks
@nickwesselman nickwesselman mentioned this pull request Dec 9, 2025
Merged
5 tasks
Base automatically changed from app_bulk_execute_no_output_file_without_watch to main December 9, 2025 20:03
@nickwesselman nickwesselman force-pushed the bulk_ops_watch_status_content branch from 4b2abcd to aa765ca Compare December 9, 2025 20:20
@nickwesselman Graphite App
Copy link
Contributor Author

nickwesselman commented Dec 10, 2025 •
edited
Loading

Merge activity

  • Dec 10, 2:12 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Dec 10, 2:12 PM UTC: @nickwesselman added this pull request to the GitHub merge queue with Graphite.

@nickwesselman nickwesselman added this pull request to the merge queue Dec 10, 2025
Merged via the queue into main with commit addb6cc Dec 10, 2025
25 checks passed
@nickwesselman nickwesselman deleted the bulk_ops_watch_status_content branch December 10, 2025 14:20
This was referenced Dec 10, 2025
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jordanverasamy jordanverasamy jordanverasamy approved these changes

@gonzaloriestra gonzaloriestra gonzaloriestra approved these changes

@ericlee878 ericlee878 ericlee878 approved these changes

Assignees

No one assigned

Labels

#gsd:47715

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nickwesselman @jordanverasamy @gonzaloriestra @ericlee878