Skip to content

Fix bug: nodes not passed correctly to SubCircuit constructor. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fsitok wants to merge 3 commits into from
Closed

Fix bug: nodes not passed correctly to SubCircuit constructor. #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
754d1cb
Fix bug: nodes not passed correctly to SubCircuit constructor.
babel-linum Feb 23, 2019
4c7c6b6
Add support for ngspice 29 and 30.
babel-linum Feb 23, 2019
3658b15
Use PosixPath.open() to be compatible with python3.5.
babel-linum Feb 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions PySpice/Spice/NgSpice/SimulationType.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,7 @@
)

SIMULATION_TYPE[28] = SIMULATION_TYPE[27]

SIMULATION_TYPE[29] = SIMULATION_TYPE[27]

SIMULATION_TYPE[30] = SIMULATION_TYPE[27]
Copy link
Collaborator

@FabriceSalvaire FabriceSalvaire Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

2 changes: 1 addition & 1 deletion PySpice/Spice/Parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def to_python(self, ground=0):

def build(self, ground=0):

subcircuit = SubCircuit(self._name, self._nodes)
subcircuit = SubCircuit(self._name, *self._nodes)
Copy link
Collaborator

@FabriceSalvaire FabriceSalvaire Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 0b02963

SpiceParser._build_circuit(subcircuit, self._statements, ground)
return subcircuit

Expand Down
2 changes: 1 addition & 1 deletion setup_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
else:
pyspice_path = pyspice_path.parent
init_path = pyspice_path.joinpath('PySpice', '__init__.py')
with open(init_path) as fh:
with init_path.open() as fh:
try:
version = re.findall(r"^__version__ = '([^']+)'\r?$", fh.read(), re.M)[0]
except IndexError:
Expand Down