Skip to content

Fix bug: nodes not passed correctly to SubCircuit constructor. #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fsitok wants to merge 3 commits into from
Closed

Fix bug: nodes not passed correctly to SubCircuit constructor. #148

fsitok wants to merge 3 commits into from

Conversation

@fsitok
Copy link

@fsitok fsitok commented Feb 23, 2019

The list of nodes needs to be expanded to multiple arguments (using *) when passed to the constructor of SubCircuit because its __init__ does not expect a list but multiple arguments:

class SubCircuit(Netlist):
    def __init__(self, name, *nodes, **kwargs):
...

@fsitok
Copy link
Author

fsitok commented Feb 23, 2019

Additionally I needed to replace open(init_path) by init_path.open() to be compatible with python3.5. Otherwise the travis check would fail.

@FabriceSalvaire FabriceSalvaire added this to the V1.3 milestone Mar 9, 2019
FabriceSalvaire
FabriceSalvaire approved these changes Mar 9, 2019
View reviewed changes
PySpice/Spice/Parser.py
def build(self, ground=0):

subcircuit = SubCircuit(self._name, self._nodes)
subcircuit = SubCircuit(self._name, *self._nodes)
Copy link
Collaborator

@FabriceSalvaire FabriceSalvaire Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done 0b02963

FabriceSalvaire
FabriceSalvaire approved these changes Mar 9, 2019
View reviewed changes
PySpice/Spice/NgSpice/SimulationType.py

SIMULATION_TYPE[29] = SIMULATION_TYPE[27]

SIMULATION_TYPE[30] = SIMULATION_TYPE[27]
Copy link
Collaborator

@FabriceSalvaire FabriceSalvaire Mar 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@FabriceSalvaire
Copy link
Collaborator

FabriceSalvaire commented Mar 9, 2019

Thanks ! fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabriceSalvaire FabriceSalvaire FabriceSalvaire approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

V1.4

Development

Successfully merging this pull request may close these issues.

3 participants

@fsitok @FabriceSalvaire @babel-linum