Skip to content

Remove obsolete dependency #14433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koppor merged 9 commits into from
Nov 27, 2025
Merged

Remove obsolete dependency #14433

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8e22e31
Remove obsolete dependency
koppor Nov 25, 2025
f31db5a
Remove empty line
koppor Nov 25, 2025
ddda603
Fix alphabetic ordering
koppor Nov 25, 2025
aa7d79f
Add ArchUnit test for jackson
koppor Nov 25, 2025
8b00fee
Re-add missing test
koppor Nov 25, 2025
0020a8f
Fix dependencies
koppor Nov 25, 2025
1950ca3
Fix spaces
koppor Nov 27, 2025
fc72d6b
Merge branch 'main' into add-arch-test-for-jackson
palukku Nov 27, 2025
5a69611
fix format test
palukku Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .jbang/JabLsLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@
//DEPS info.picocli:picocli:4.7.7

// from jabls
//DEPS com.fasterxml.jackson.core:jackson-annotations:2.20
//DEPS tools.jackson.core:jackson-core:3.0.2
//DEPS tools.jackson.core:jackson-databind:3.0.2
//DEPS tools.jackson.dataformat:jackson-dataformat-yaml:3.0.2
//DEPS info.picocli:picocli:4.7.7
//DEPS org.apache.logging.log4j:log4j-to-slf4j:2.25.2
//DEPS org.eclipse.lsp4j:org.eclipse.lsp4j:0.24.0
Expand All @@ -28,6 +24,9 @@
//DEPS org.tinylog:tinylog-impl:2.7.0
//DEPS com.github.ben-manes.caffeine:caffeine:3.2.3
//DEPS org.apache.commons:commons-lang3:3.20.0
//DEPS tools.jackson.core:jackson-core:3.0.2
Copy link
Member

@Siedlerchr Siedlerchr Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need the annotations for stuff like @JSON...

Copy link
Member Author

@koppor koppor Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not really get why, but I needed to re-add.

But I could remove other dependencies as they should come in via jablib transitive dependencies.

//DEPS tools.jackson.core:jackson-databind:3.0.2
//DEPS tools.jackson.dataformat:jackson-dataformat-yaml:3.0.2

//SOURCES ../jabls/src/main/java/org/jabref/languageserver/BibtexTextDocumentService.java
//SOURCES ../jabls/src/main/java/org/jabref/languageserver/BibtexWorkspaceService.java
Expand Down
1 change: 0 additions & 1 deletion jablib/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,6 @@ javaModuleTesting.whitebox(testing.suites["test"]) {
requires.add("org.xmlunit")
requires.add("org.xmlunit.matchers")


requires.add("com.tngtech.archunit")
requires.add("com.tngtech.archunit.junit5.api")
}
18 changes: 17 additions & 1 deletion test-support/src/main/java/org/jabref/support/CommonArchitectureTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@
import com.tngtech.archunit.lang.syntax.ArchRuleDefinition;
import com.tngtech.archunit.library.GeneralCodingRules;

import static com.tngtech.archunit.base.DescribedPredicate.not;
import static com.tngtech.archunit.core.domain.JavaClass.Predicates.resideInAnyPackage;

/**
* This class checks JabRef's shipped classes for architecture quality.
* Does not analyze test classes. Hint from <a href="https://stackoverflow.com/a/44681895/873282">StackOverflow</a>
Expand Down Expand Up @@ -57,6 +60,19 @@ public void doNotUseSwing(JavaClasses classes) {
.check(classes);
}

@ArchTest
public void doNotUseJackson2(JavaClasses classes) {
// annotations still reside in com.fasterxml package:
ArchRuleDefinition.noClasses()
.should()
.dependOnClassesThat(
resideInAnyPackage("com.fasterxml..")
// https://github.com/FasterXML/jackson-databind/blob/37b593e4836af62a267f09d2193414078df36eb0/src/test/java/tools/jackson/databind/deser/AnySetterTest.java#L7C8-L7C42
.and(not(resideInAnyPackage("com.fasterxml.jackson.annotation..")))
)
.check(classes);
}

@ArchTest
public void doNotUseAssertJ(JavaClasses classes) {
ArchRuleDefinition.noClasses().should().accessClassesThat().resideInAPackage("org.assertj..")
Expand All @@ -66,7 +82,7 @@ public void doNotUseAssertJ(JavaClasses classes) {
@ArchTest
public void doNotUseJavaAWT(JavaClasses classes) {
ArchRuleDefinition.noClasses().that().areNotAnnotatedWith(AllowedToUseAwt.class)
.should().accessClassesThat().resideInAPackage(PACKAGE_JAVA_AWT)
.should().dependOnClassesThat().resideInAPackage(PACKAGE_JAVA_AWT)
.check(classes);
}

Expand Down
Loading