Skip to content

Remove obsolete dependency #14433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 27, 2025
Merged

Remove obsolete dependency #14433

merged 9 commits into from
Nov 27, 2025

Conversation

@koppor
Copy link
Member

@koppor koppor commented Nov 25, 2025

Follow-up to #14259

Refs https://github.com/FasterXML/jackson/blob/main/jackson3/MIGRATING_TO_JACKSON_3.md

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@koppor koppor added dev: code-quality Issues related to code or architecture decisions dev: testing Related to tests labels Nov 25, 2025
Siedlerchr
Siedlerchr reviewed Nov 25, 2025
View reviewed changes
.jbang/JabLsLauncher.java Outdated
//DEPS org.tinylog:tinylog-impl:2.7.0
//DEPS com.github.ben-manes.caffeine:caffeine:3.2.3
//DEPS org.apache.commons:commons-lang3:3.20.0
//DEPS tools.jackson.core:jackson-core:3.0.2
Copy link
Member

@Siedlerchr Siedlerchr Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need the annotations for stuff like @JSON...

Copy link
Member Author

@koppor koppor Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I not really get why, but I needed to re-add.

But I could remove other dependencies as they should come in via jablib transitive dependencies.

@koppor koppor enabled auto-merge November 27, 2025 12:58
palukku
palukku previously approved these changes Nov 27, 2025
View reviewed changes
Copy link
Member

@palukku palukku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move fast :)

@koppor koppor added this pull request to the merge queue Nov 27, 2025
Merged via the queue into main with commit 2062ca9 Nov 27, 2025
53 checks passed
@koppor koppor deleted the add-arch-test-for-jackson branch November 27, 2025 14:42
shubhamk0205 pushed a commit to shubhamk0205/jabref that referenced this pull request Dec 3, 2025
@koppor @palukku @shubhamk0205
Remove obsolete dependency (JabRef#14433)
c8549af 
* Remove obsolete dependency

* Remove empty line

* Fix alphabetic ordering

* Add ArchUnit test for jackson

* Re-add missing test

* Fix dependencies

* Fix spaces

* fix format test

---------

Co-authored-by: Philip <37398281+palukku@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

@palukku palukku palukku approved these changes

Assignees

No one assigned

Labels

dev: code-quality Issues related to code or architecture decisions dev: testing Related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koppor @Siedlerchr @palukku