Fine tune clang-tidy

.clang-tidy

@@ -1,8 +1,12 @@
-WarningsAsErrors: "*"
+WarningsAsErrors: "" # "*" for Werror behaviour.
 UseColor: true
 HeaderFilterRegex: '^(?!MPI_api.h$|PETSc_api.h$).*' # Pulled in from python packages and not classified as system headers
 ExtraArgsBefore:
   - '-Wno-unknown-warning-option'
 Checks: >
   -*,
   performance*
+CheckOptions:
+  # Design decision: pass nb::ndarray by value, not const ref.
+  - key: performance-unnecessary-value-param.AllowedTypes
+    value: 'nanobind::ndarray'

.github/workflows/clang-tidy.yml

@@ -1,9 +1,9 @@
 name: clang-tidy
 
 on:
-  # schedule:
-  #   # daily at 1am
-  #   - cron: "0 1 * * *"
+  schedule:
+    # daily at 1am
+    - cron: "0 1 * * *"
   # pull_request:
   #   branches:
   #     - main

cpp/dolfinx/graph/utils.cpp

@@ -94,6 +94,7 @@ graph::comm_graph(const common::IndexMap& map, int root)
   dolfinx::MPI::check_error(comm, ierr);
 
   std::vector<std::tuple<int, std::size_t, std::int8_t>> e_data;
+  e_data.reserve(edges_remote.size());
   for (std::size_t i = 0; i < edges_remote.size(); ++i)
     e_data.emplace_back(edges_remote[i], weights_remote[i], markers_remote[i]);
   return graph::AdjacencyList(std::move(e_data),