Skip to content
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 25 additions & 7 deletions sdk/batch/arm-batch/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,33 @@
# Release History

## 9.0.0 (2023-06-30)

**Features**

## 8.0.1 (Unreleased)

### Features Added

### Breaking Changes
- Added Type Alias ContainerType
- Interface NetworkConfiguration has a new optional parameter enableAcceleratedNetworking
- Interface VMExtension has a new optional parameter enableAutomaticUpgrade
- Added Enum KnownContainerType
- Interface ApplicationListNextOptionalParams no longer has parameter maxresults
- Interface ApplicationPackageListNextOptionalParams no longer has parameter maxresults
- Interface CertificateListByBatchAccountNextOptionalParams no longer has parameter filter
- Interface CertificateListByBatchAccountNextOptionalParams no longer has parameter maxresults
- Interface CertificateListByBatchAccountNextOptionalParams no longer has parameter select
- Interface LocationListSupportedCloudServiceSkusNextOptionalParams no longer has parameter filter
- Interface LocationListSupportedCloudServiceSkusNextOptionalParams no longer has parameter maxresults
- Interface LocationListSupportedVirtualMachineSkusNextOptionalParams no longer has parameter filter
- Interface LocationListSupportedVirtualMachineSkusNextOptionalParams no longer has parameter maxresults
- Interface PoolListByBatchAccountNextOptionalParams no longer has parameter filter
- Interface PoolListByBatchAccountNextOptionalParams no longer has parameter maxresults
- Interface PoolListByBatchAccountNextOptionalParams no longer has parameter select
- Interface PrivateEndpointConnectionListByBatchAccountNextOptionalParams no longer has parameter maxresults
- Interface PrivateLinkResourceListByBatchAccountNextOptionalParams no longer has parameter maxresults

### Bugs Fixed
**Breaking Changes**

### Other Changes
- Type of parameter type of interface ContainerConfiguration is changed from "DockerCompatible" to ContainerType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kazrael2119 Could you help refer the breaking pr?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaking is acceptable and un-aviodeable.



## 8.0.0 (2022-11-10)

**Features**
Expand Down
2 changes: 1 addition & 1 deletion sdk/batch/arm-batch/LICENSE
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
The MIT License (MIT)

Copyright (c) 2022 Microsoft
Copyright (c) 2023 Microsoft

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
Expand Down
8 changes: 4 additions & 4 deletions sdk/batch/arm-batch/_meta.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"commit": "05fc1b443a1ba7b120a48e1ad204d267565ef57a",
"commit": "64efc48302878a07d1d1231eaed0ca9cadfaf037",
"readme": "specification/batch/resource-manager/readme.md",
"autorest_command": "autorest --version=3.8.4 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\Git\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\batch\\resource-manager\\readme.md --use=@autorest/typescript@6.0.0-rc.3.20221108.1 --generate-sample=true",
"autorest_command": "autorest --version=3.9.3 --typescript --modelerfour.lenient-model-deduplication --azure-arm --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\Git\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\batch\\resource-manager\\readme.md --use=@autorest/typescript@6.0.5 --generate-sample=true",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"release_tool": "@azure-tools/js-sdk-release-tools@2.4.2",
"use": "@autorest/typescript@6.0.0-rc.3.20221108.1"
"release_tool": "@azure-tools/js-sdk-release-tools@2.7.0",
"use": "@autorest/typescript@6.0.5"
}
2 changes: 1 addition & 1 deletion sdk/batch/arm-batch/assets.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"AssetsRepo": "Azure/azure-sdk-assets",
"AssetsRepoPrefixPath": "js",
"TagPrefix": "js/batch/arm-batch",
"Tag": "js/batch/arm-batch_7d52e8edfe"
"Tag": "js/batch/arm-batch_beed3813b7"
}
11 changes: 6 additions & 5 deletions sdk/batch/arm-batch/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,15 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for BatchManagementClient.",
"version": "8.0.1",
"version": "9.0.0",
"engines": {
"node": ">=14.0.0"
},
"dependencies": {
"@azure/core-lro": "^2.2.0",
"@azure/core-lro": "^2.5.3",
"@azure/abort-controller": "^1.0.0",
"@azure/core-paging": "^1.2.0",
"@azure/core-client": "^1.6.1",
"@azure/core-client": "^1.7.0",
"@azure/core-auth": "^1.3.0",
"@azure/core-rest-pipeline": "^1.8.0",
"tslib": "^2.2.0"
Expand All @@ -33,12 +33,13 @@
"@rollup/plugin-json": "^6.0.0",
"@rollup/plugin-multi-entry": "^6.0.0",
"@rollup/plugin-node-resolve": "^13.1.3",
"mkdirp": "^1.0.4",
"mkdirp": "^2.1.2",
"rollup": "^2.66.1",
"rollup-plugin-sourcemaps": "^0.6.3",
"typescript": "~5.0.0",
"uglify-js": "^3.4.9",
"rimraf": "^3.0.0",
"dotenv": "^16.0.0",
"@azure/identity": "^2.0.1",
"@azure-tools/test-recorder": "^3.0.0",
"@azure-tools/test-credential": "^1.0.0",
Expand All @@ -50,7 +51,6 @@
"@azure/dev-tool": "^1.0.0",
"@azure/arm-storage": "^17.1.0"
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/batch/arm-batch",
"repository": {
"type": "git",
"url": "https://github.com/Azure/azure-sdk-for-js.git"
Expand Down Expand Up @@ -112,6 +112,7 @@
]
},
"autoPublish": true,
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/batch/arm-batch",
"//sampleConfiguration": {
"productName": "",
"productSlugs": [
Expand Down
43 changes: 20 additions & 23 deletions sdk/batch/arm-batch/review/arm-batch.api.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@

import * as coreAuth from '@azure/core-auth';
import * as coreClient from '@azure/core-client';
import { OperationState } from '@azure/core-lro';
import { PagedAsyncIterableIterator } from '@azure/core-paging';
import { PollerLike } from '@azure/core-lro';
import { PollOperationState } from '@azure/core-lro';
import { SimplePollerLike } from '@azure/core-lro';

// @public
export type AccountKeyType = "Primary" | "Secondary";
Expand Down Expand Up @@ -49,7 +49,6 @@ export type ApplicationGetResponse = Application;

// @public
export interface ApplicationListNextOptionalParams extends coreClient.OperationOptions {
maxresults?: number;
}

// @public
Expand Down Expand Up @@ -109,7 +108,6 @@ export type ApplicationPackageGetResponse = ApplicationPackage;

// @public
export interface ApplicationPackageListNextOptionalParams extends coreClient.OperationOptions {
maxresults?: number;
}

// @public
Expand Down Expand Up @@ -379,9 +377,9 @@ export interface BatchAccountListResult {

// @public
export interface BatchAccountOperations {
beginCreate(resourceGroupName: string, accountName: string, parameters: BatchAccountCreateParameters, options?: BatchAccountCreateOptionalParams): Promise<PollerLike<PollOperationState<BatchAccountCreateResponse>, BatchAccountCreateResponse>>;
beginCreate(resourceGroupName: string, accountName: string, parameters: BatchAccountCreateParameters, options?: BatchAccountCreateOptionalParams): Promise<SimplePollerLike<OperationState<BatchAccountCreateResponse>, BatchAccountCreateResponse>>;
beginCreateAndWait(resourceGroupName: string, accountName: string, parameters: BatchAccountCreateParameters, options?: BatchAccountCreateOptionalParams): Promise<BatchAccountCreateResponse>;
beginDelete(resourceGroupName: string, accountName: string, options?: BatchAccountDeleteOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
beginDelete(resourceGroupName: string, accountName: string, options?: BatchAccountDeleteOptionalParams): Promise<SimplePollerLike<OperationState<void>, void>>;
beginDeleteAndWait(resourceGroupName: string, accountName: string, options?: BatchAccountDeleteOptionalParams): Promise<void>;
get(resourceGroupName: string, accountName: string, options?: BatchAccountGetOptionalParams): Promise<BatchAccountGetResponse>;
getDetector(resourceGroupName: string, accountName: string, detectorId: string, options?: BatchAccountGetDetectorOptionalParams): Promise<BatchAccountGetDetectorResponse>;
Expand Down Expand Up @@ -573,9 +571,6 @@ export type CertificateGetResponse = CertificateGetHeaders & Certificate;

// @public
export interface CertificateListByBatchAccountNextOptionalParams extends coreClient.OperationOptions {
filter?: string;
maxresults?: number;
select?: string;
}

// @public
Expand All @@ -593,7 +588,7 @@ export type CertificateListByBatchAccountResponse = ListCertificatesResult;

// @public
export interface CertificateOperations {
beginDelete(resourceGroupName: string, accountName: string, certificateName: string, options?: CertificateDeleteOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
beginDelete(resourceGroupName: string, accountName: string, certificateName: string, options?: CertificateDeleteOptionalParams): Promise<SimplePollerLike<OperationState<void>, void>>;
beginDeleteAndWait(resourceGroupName: string, accountName: string, certificateName: string, options?: CertificateDeleteOptionalParams): Promise<void>;
cancelDeletion(resourceGroupName: string, accountName: string, certificateName: string, options?: CertificateCancelDeletionOptionalParams): Promise<CertificateCancelDeletionResponse>;
create(resourceGroupName: string, accountName: string, certificateName: string, parameters: CertificateCreateOrUpdateParameters, options?: CertificateCreateOptionalParams): Promise<CertificateCreateResponse>;
Expand Down Expand Up @@ -698,7 +693,7 @@ export interface ComputeNodeIdentityReference {
export interface ContainerConfiguration {
containerImageNames?: string[];
containerRegistries?: ContainerRegistry[];
type: "DockerCompatible";
type: ContainerType;
}

// @public
Expand All @@ -709,6 +704,9 @@ export interface ContainerRegistry {
userName?: string;
}

// @public
export type ContainerType = string;

// @public
export type ContainerWorkingDirectory = "TaskWorkingDirectory" | "ContainerImageDefault";

Expand Down Expand Up @@ -856,6 +854,12 @@ export interface KeyVaultReference {
url: string;
}

// @public
export enum KnownContainerType {
CriCompatible = "CriCompatible",
DockerCompatible = "DockerCompatible"
}

// @public
export interface LinuxUserConfiguration {
gid?: number;
Expand Down Expand Up @@ -924,8 +928,6 @@ export type LocationGetQuotasResponse = BatchLocationQuota;

// @public
export interface LocationListSupportedCloudServiceSkusNextOptionalParams extends coreClient.OperationOptions {
filter?: string;
maxresults?: number;
}

// @public
Expand All @@ -942,8 +944,6 @@ export type LocationListSupportedCloudServiceSkusResponse = SupportedSkusResult;

// @public
export interface LocationListSupportedVirtualMachineSkusNextOptionalParams extends coreClient.OperationOptions {
filter?: string;
maxresults?: number;
}

// @public
Expand Down Expand Up @@ -981,6 +981,7 @@ export type NameAvailabilityReason = "Invalid" | "AlreadyExists";
// @public
export interface NetworkConfiguration {
dynamicVnetAssignmentScope?: DynamicVNetAssignmentScope;
enableAcceleratedNetworking?: boolean;
endpointConfiguration?: PoolEndpointConfiguration;
publicIPAddressConfiguration?: PublicIPAddressConfiguration;
subnetId?: string;
Expand Down Expand Up @@ -1178,9 +1179,6 @@ export type PoolIdentityType = "UserAssigned" | "None";

// @public
export interface PoolListByBatchAccountNextOptionalParams extends coreClient.OperationOptions {
filter?: string;
maxresults?: number;
select?: string;
}

// @public
Expand All @@ -1198,7 +1196,7 @@ export type PoolListByBatchAccountResponse = ListPoolsResult;

// @public
export interface PoolOperations {
beginDelete(resourceGroupName: string, accountName: string, poolName: string, options?: PoolDeleteOptionalParams): Promise<PollerLike<PollOperationState<void>, void>>;
beginDelete(resourceGroupName: string, accountName: string, poolName: string, options?: PoolDeleteOptionalParams): Promise<SimplePollerLike<OperationState<void>, void>>;
beginDeleteAndWait(resourceGroupName: string, accountName: string, poolName: string, options?: PoolDeleteOptionalParams): Promise<void>;
create(resourceGroupName: string, accountName: string, poolName: string, parameters: Pool, options?: PoolCreateOptionalParams): Promise<PoolCreateResponse>;
disableAutoScale(resourceGroupName: string, accountName: string, poolName: string, options?: PoolDisableAutoScaleOptionalParams): Promise<PoolDisableAutoScaleResponse>;
Expand Down Expand Up @@ -1273,7 +1271,6 @@ export type PrivateEndpointConnectionGetResponse = PrivateEndpointConnection;

// @public
export interface PrivateEndpointConnectionListByBatchAccountNextOptionalParams extends coreClient.OperationOptions {
maxresults?: number;
}

// @public
Expand All @@ -1289,9 +1286,9 @@ export type PrivateEndpointConnectionListByBatchAccountResponse = ListPrivateEnd

// @public
export interface PrivateEndpointConnectionOperations {
beginDelete(resourceGroupName: string, accountName: string, privateEndpointConnectionName: string, options?: PrivateEndpointConnectionDeleteOptionalParams): Promise<PollerLike<PollOperationState<PrivateEndpointConnectionDeleteResponse>, PrivateEndpointConnectionDeleteResponse>>;
beginDelete(resourceGroupName: string, accountName: string, privateEndpointConnectionName: string, options?: PrivateEndpointConnectionDeleteOptionalParams): Promise<SimplePollerLike<OperationState<PrivateEndpointConnectionDeleteResponse>, PrivateEndpointConnectionDeleteResponse>>;
beginDeleteAndWait(resourceGroupName: string, accountName: string, privateEndpointConnectionName: string, options?: PrivateEndpointConnectionDeleteOptionalParams): Promise<PrivateEndpointConnectionDeleteResponse>;
beginUpdate(resourceGroupName: string, accountName: string, privateEndpointConnectionName: string, parameters: PrivateEndpointConnection, options?: PrivateEndpointConnectionUpdateOptionalParams): Promise<PollerLike<PollOperationState<PrivateEndpointConnectionUpdateResponse>, PrivateEndpointConnectionUpdateResponse>>;
beginUpdate(resourceGroupName: string, accountName: string, privateEndpointConnectionName: string, parameters: PrivateEndpointConnection, options?: PrivateEndpointConnectionUpdateOptionalParams): Promise<SimplePollerLike<OperationState<PrivateEndpointConnectionUpdateResponse>, PrivateEndpointConnectionUpdateResponse>>;
beginUpdateAndWait(resourceGroupName: string, accountName: string, privateEndpointConnectionName: string, parameters: PrivateEndpointConnection, options?: PrivateEndpointConnectionUpdateOptionalParams): Promise<PrivateEndpointConnectionUpdateResponse>;
get(resourceGroupName: string, accountName: string, privateEndpointConnectionName: string, options?: PrivateEndpointConnectionGetOptionalParams): Promise<PrivateEndpointConnectionGetResponse>;
listByBatchAccount(resourceGroupName: string, accountName: string, options?: PrivateEndpointConnectionListByBatchAccountOptionalParams): PagedAsyncIterableIterator<PrivateEndpointConnection>;
Expand Down Expand Up @@ -1332,7 +1329,6 @@ export type PrivateLinkResourceGetResponse = PrivateLinkResource;

// @public
export interface PrivateLinkResourceListByBatchAccountNextOptionalParams extends coreClient.OperationOptions {
maxresults?: number;
}

// @public
Expand Down Expand Up @@ -1520,6 +1516,7 @@ export interface VirtualMachineFamilyCoreQuota {
// @public
export interface VMExtension {
autoUpgradeMinorVersion?: boolean;
enableAutomaticUpgrade?: boolean;
name: string;
protectedSettings?: Record<string, unknown>;
provisionAfterExtensions?: string[];
Expand Down
16 changes: 12 additions & 4 deletions sdk/batch/arm-batch/samples-dev/applicationCreateSample.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,16 +14,20 @@ import {
BatchManagementClient
} from "@azure/arm-batch";
import { DefaultAzureCredential } from "@azure/identity";
import * as dotenv from "dotenv";

dotenv.config();

/**
* This sample demonstrates how to Adds an application to the specified Batch account.
*
* @summary Adds an application to the specified Batch account.
* x-ms-original-file: specification/batch/resource-manager/Microsoft.Batch/stable/2022-10-01/examples/ApplicationCreate.json
* x-ms-original-file: specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/examples/ApplicationCreate.json
*/
async function applicationCreate() {
const subscriptionId = "subid";
const resourceGroupName = "default-azurebatch-japaneast";
const subscriptionId = process.env["BATCH_SUBSCRIPTION_ID"] || "subid";
const resourceGroupName =
process.env["BATCH_RESOURCE_GROUP"] || "default-azurebatch-japaneast";
const accountName = "sampleacct";
const applicationName = "app1";
const parameters: Application = {
Expand All @@ -42,4 +46,8 @@ async function applicationCreate() {
console.log(result);
}

applicationCreate().catch(console.error);
async function main() {
applicationCreate();
}

main().catch(console.error);
16 changes: 12 additions & 4 deletions sdk/batch/arm-batch/samples-dev/applicationDeleteSample.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,20 @@
// Licensed under the MIT License.
import { BatchManagementClient } from "@azure/arm-batch";
import { DefaultAzureCredential } from "@azure/identity";
import * as dotenv from "dotenv";

dotenv.config();

/**
* This sample demonstrates how to Deletes an application.
*
* @summary Deletes an application.
* x-ms-original-file: specification/batch/resource-manager/Microsoft.Batch/stable/2022-10-01/examples/ApplicationDelete.json
* x-ms-original-file: specification/batch/resource-manager/Microsoft.Batch/stable/2023-05-01/examples/ApplicationDelete.json
*/
async function applicationDelete() {
const subscriptionId = "subid";
const resourceGroupName = "default-azurebatch-japaneast";
const subscriptionId = process.env["BATCH_SUBSCRIPTION_ID"] || "subid";
const resourceGroupName =
process.env["BATCH_RESOURCE_GROUP"] || "default-azurebatch-japaneast";
const accountName = "sampleacct";
const applicationName = "app1";
const credential = new DefaultAzureCredential();
Expand All @@ -32,4 +36,8 @@ async function applicationDelete() {
console.log(result);
}

applicationDelete().catch(console.error);
async function main() {
applicationDelete();
}

main().catch(console.error);
Loading