-
Notifications
You must be signed in to change notification settings - Fork 1.3k
batch release #26369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch release #26369
Conversation
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
| **Breaking Changes** | ||
|
|
||
| ### Other Changes | ||
| - Type of parameter type of interface ContainerConfiguration is changed from "DockerCompatible" to ContainerType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kazrael2119 Could you help refer the breaking pr?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaking is acceptable and un-aviodeable.
MaryGao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
https://github.com/Azure/sdk-release-request/issues/4242
Recording: https://github.com/Azure/azure-sdk-assets/tree/js/batch/arm-batch_beed3813b7