-
Notifications
You must be signed in to change notification settings - Fork 5.6k
[Microsoft.DeviceUpdate] Private Link - Added Network RP required properties #17042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
b8165ef
Added group IDs array to PrivateEndpointConnection in v4 common type
darkoa-msft 1cfe266
Added private endpoint connections to the top level resource
darkoa-msft e4e1afa
Updated examples
darkoa-msft fc7fd35
Added types.json to commopn-types/v4
darkoa-msft e70e052
Moved new version of privatelinks.json into our directory
darkoa-msft 88f1619
Wrong level
darkoa-msft 7fbd577
Added period to the end of description for consistency
darkoa-msft 61ff78b
Updated version in privatelinks.json
darkoa-msft 971366b
Removed duplicate resource from privatelinks.json
darkoa-msft f35d1ce
Merge branch 'Azure:main' into main
darkoa-msft 2dce8c7
Made PrivateEndpointConnection.properties required, added PEC payload…
darkoa-msft 8e21124
Added Operations List example
darkoa-msft 614d256
Referenced Operations example file from the swagger
darkoa-msft d6c313c
Reduce number of operations in the Operations_List example
darkoa-msft 84966af
Fixed Operations List example
darkoa-msft 02b9ae7
Removed PrivateEnpointConnection from Account update example
darkoa-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
176 changes: 176 additions & 0 deletions
176
...date/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/privatelinks.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,176 @@ | ||
| { | ||
| "swagger": "2.0", | ||
| "info": { | ||
| "version": "2020-03-01-preview", | ||
| "title": "Common private link types" | ||
| }, | ||
| "paths": {}, | ||
| "definitions": { | ||
| "PrivateEndpoint": { | ||
| "type": "object", | ||
| "properties": { | ||
| "id": { | ||
| "readOnly": true, | ||
| "type": "string", | ||
| "description": "The ARM identifier for Private Endpoint" | ||
| } | ||
| }, | ||
| "description": "The Private Endpoint resource." | ||
| }, | ||
| "PrivateEndpointConnection": { | ||
| "type": "object", | ||
| "properties": { | ||
| "properties": { | ||
| "$ref": "#/definitions/PrivateEndpointConnectionProperties", | ||
| "x-ms-client-flatten": true, | ||
| "description": "Resource properties." | ||
| } | ||
| }, | ||
| "allOf": [ | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/Resource" | ||
| } | ||
| ], | ||
| "description": "The Private Endpoint Connection resource." | ||
| }, | ||
| "PrivateEndpointConnectionProperties": { | ||
| "type": "object", | ||
| "properties": { | ||
| "privateEndpoint": { | ||
| "$ref": "#/definitions/PrivateEndpoint", | ||
| "description": "The resource of private end point." | ||
| }, | ||
| "privateLinkServiceConnectionState": { | ||
| "$ref": "#/definitions/PrivateLinkServiceConnectionState", | ||
| "description": "A collection of information about the state of the connection between service consumer and provider." | ||
| }, | ||
| "groupIds": { | ||
| "type": "array", | ||
| "description": "Array of group IDs.", | ||
| "items": { | ||
| "type": "string" | ||
| } | ||
| }, | ||
| "provisioningState": { | ||
| "$ref": "#/definitions/PrivateEndpointConnectionProvisioningState", | ||
| "description": "The provisioning state of the private endpoint connection resource." | ||
| } | ||
| }, | ||
| "required": [ | ||
| "privateLinkServiceConnectionState" | ||
| ], | ||
| "description": "Properties of the PrivateEndpointConnectProperties." | ||
| }, | ||
| "PrivateLinkServiceConnectionState": { | ||
| "type": "object", | ||
| "properties": { | ||
darkoa-msft marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "status": { | ||
| "$ref": "#/definitions/PrivateEndpointServiceConnectionStatus", | ||
| "description": "Indicates whether the connection has been Approved/Rejected/Removed by the owner of the service." | ||
| }, | ||
| "description": { | ||
| "type": "string", | ||
| "description": "The reason for approval/rejection of the connection." | ||
| }, | ||
| "actionsRequired": { | ||
| "type": "string", | ||
| "description": "A message indicating if changes on the service provider require any updates on the consumer." | ||
| } | ||
| }, | ||
| "description": "A collection of information about the state of the connection between service consumer and provider." | ||
| }, | ||
| "PrivateEndpointServiceConnectionStatus": { | ||
| "type": "string", | ||
| "description": "The private endpoint connection status.", | ||
| "enum": [ | ||
| "Pending", | ||
| "Approved", | ||
| "Rejected" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "PrivateEndpointServiceConnectionStatus", | ||
| "modelAsString": true | ||
| } | ||
| }, | ||
| "PrivateEndpointConnectionProvisioningState": { | ||
| "type": "string", | ||
| "readOnly": true, | ||
| "description": "The current provisioning state.", | ||
| "enum": [ | ||
| "Succeeded", | ||
| "Creating", | ||
| "Deleting", | ||
| "Failed" | ||
| ], | ||
| "x-ms-enum": { | ||
| "name": "PrivateEndpointConnectionProvisioningState", | ||
| "modelAsString": true | ||
| } | ||
| }, | ||
| "PrivateLinkResource": { | ||
| "type": "object", | ||
| "properties": { | ||
| "properties": { | ||
| "$ref": "#/definitions/PrivateLinkResourceProperties", | ||
| "description": "Resource properties.", | ||
| "x-ms-client-flatten": true | ||
| } | ||
| }, | ||
| "allOf": [ | ||
| { | ||
| "$ref": "../../../../../common-types/resource-management/v3/types.json#/definitions/Resource" | ||
| } | ||
| ], | ||
| "description": "A private link resource" | ||
| }, | ||
| "PrivateLinkResourceProperties": { | ||
| "type": "object", | ||
| "properties": { | ||
| "groupId": { | ||
| "description": "The private link resource group id.", | ||
| "type": "string", | ||
| "readOnly": true | ||
| }, | ||
| "requiredMembers": { | ||
| "description": "The private link resource required member names.", | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "readOnly": true | ||
| }, | ||
| "requiredZoneNames": { | ||
| "type": "array", | ||
| "items": { | ||
| "type": "string" | ||
| }, | ||
| "description": "The private link resource Private link DNS zone name." | ||
| } | ||
| }, | ||
| "description": "Properties of a private link resource." | ||
| }, | ||
| "PrivateEndpointConnectionListResult": { | ||
| "type": "object", | ||
| "properties": { | ||
| "value": { | ||
| "type": "array", | ||
| "description": "Array of private endpoint connections", | ||
| "items": { | ||
| "$ref": "#/definitions/PrivateEndpointConnection" | ||
| } | ||
| } | ||
| }, | ||
| "description": "List of private endpoint connection associated with the specified storage account" | ||
| } | ||
| }, | ||
| "parameters": { | ||
| "PrivateEndpointConnectionName": { | ||
| "name": "privateEndpointConnectionName", | ||
| "in": "path", | ||
| "required": true, | ||
| "type": "string", | ||
| "description": "The name of the private endpoint connection associated with the Azure resource", | ||
| "x-ms-parameter-location": "method" | ||
| } | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.