Skip to content

[Microsoft.DeviceUpdate] Private Link - Added Network RP required properties #17042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raych1 merged 16 commits into from
Dec 13, 2021
Merged

[Microsoft.DeviceUpdate] Private Link - Added Network RP required properties #17042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b8165ef
Added group IDs array to PrivateEndpointConnection in v4 common type
darkoa-msft Dec 10, 2021
1cfe266
Added private endpoint connections to the top level resource
darkoa-msft Dec 10, 2021
e4e1afa
Updated examples
darkoa-msft Dec 10, 2021
fc7fd35
Added types.json to commopn-types/v4
darkoa-msft Dec 10, 2021
e70e052
Moved new version of privatelinks.json into our directory
darkoa-msft Dec 10, 2021
88f1619
Wrong level
darkoa-msft Dec 10, 2021
7fbd577
Added period to the end of description for consistency
darkoa-msft Dec 10, 2021
61ff78b
Updated version in privatelinks.json
darkoa-msft Dec 10, 2021
971366b
Removed duplicate resource from privatelinks.json
darkoa-msft Dec 10, 2021
f35d1ce
Merge branch 'Azure:main' into main
darkoa-msft Dec 13, 2021
2dce8c7
Made PrivateEndpointConnection.properties required, added PEC payload…
darkoa-msft Dec 13, 2021
8e21124
Added Operations List example
darkoa-msft Dec 13, 2021
614d256
Referenced Operations example file from the swagger
darkoa-msft Dec 13, 2021
d6c313c
Reduce number of operations in the Operations_List example
darkoa-msft Dec 13, 2021
84966af
Fixed Operations List example
darkoa-msft Dec 13, 2021
02b9ae7
Removed PrivateEnpointConnection from Account update example
darkoa-msft Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions ...date/resource-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/deviceupdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@
"200": {
"description": "The request was successful; the request was well-formed and received properly.",
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateEndpointConnectionListResult"
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnectionListResult"
}
},
"default": {
Expand Down Expand Up @@ -716,14 +716,14 @@
"$ref": "#/parameters/AccountNameParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/parameters/PrivateEndpointConnectionName"
"$ref": "./privatelinks.json#/parameters/PrivateEndpointConnectionName"
}
],
"responses": {
"200": {
"description": "The request was successful; the request was well-formed and received properly.",
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateEndpointConnection"
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnection"
}
},
"default": {
Expand Down Expand Up @@ -759,23 +759,23 @@
"$ref": "#/parameters/AccountNameParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/parameters/PrivateEndpointConnectionName"
"$ref": "./privatelinks.json#/parameters/PrivateEndpointConnectionName"
},
{
"name": "privateEndpointConnection",
"in": "body",
"description": "The parameters for creating a private endpoint connection.",
"required": true,
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateEndpointConnection"
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnection"
}
}
],
"responses": {
"201": {
"description": "The request was successful; the operation will complete asynchronously.",
"schema": {
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateEndpointConnection"
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnection"
}
},
"default": {
Expand Down Expand Up @@ -815,7 +815,7 @@
"$ref": "#/parameters/AccountNameParameter"
},
{
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/parameters/PrivateEndpointConnectionName"
"$ref": "./privatelinks.json#/parameters/PrivateEndpointConnectionName"
}
],
"responses": {
Expand Down Expand Up @@ -1207,6 +1207,11 @@
"deprecated": false,
"x-ms-pageable": {
"nextLinkName": "nextLink"
},
"x-ms-examples": {
"Gets list of Operations": {
"$ref": "./examples/Operations_List.json"
}
}
}
}
Expand Down Expand Up @@ -1249,7 +1254,7 @@
"readOnly": true
},
"publicNetworkAccess": {
"description": "Whether or not public network access is allowed for the container registry.",
"description": "Whether or not public network access is allowed for the account.",
"default": "Enabled",
"enum": [
"Enabled",
Expand All @@ -1260,6 +1265,13 @@
"name": "PublicNetworkAccess",
"modelAsString": true
}
},
"privateEndpointConnections": {
"description": "List of private endpoint connections associated with the account.",
"type": "array",
"items": {
"$ref": "./privatelinks.json#/definitions/PrivateEndpointConnection"
}
}
}
},
Expand Down Expand Up @@ -1489,7 +1501,7 @@
"type": "object",
"allOf": [
{
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateLinkResourceProperties"
"$ref": "./privatelinks.json#/definitions/PrivateLinkResourceProperties"
}
],
"properties": {
Expand Down Expand Up @@ -1636,7 +1648,7 @@
},
"remotePrivateLinkServiceConnectionState": {
"description": "Remote private link service connection state",
"$ref": "../../../../../common-types/resource-management/v3/privatelinks.json#/definitions/PrivateLinkServiceConnectionState"
"$ref": "./privatelinks.json#/definitions/PrivateLinkServiceConnectionState"
},
"remotePrivateEndpointConnection": {
"description": "Remote private endpoint connection details.",
Expand Down
3 changes: 2 additions & 1 deletion .../Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Accounts/Accounts_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
"type": "Microsoft.DeviceUpdate/accounts",
"properties": {
"provisioningState": "Accepted",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": []
}
}
}
Expand Down
23 changes: 22 additions & 1 deletion ...ger/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Accounts/Accounts_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,28 @@
"type": "Microsoft.DeviceUpdate/accounts",
"properties": {
"provisioningState": "Succeeded",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": [
{
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnections/peexample01",
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
},
"groupIds": [
"groupId"
]
}
}
]
}
}
}
Expand Down
23 changes: 22 additions & 1 deletion ...er/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Accounts/Accounts_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,28 @@
"type": "Microsoft.DeviceUpdate/accounts",
"properties": {
"provisioningState": "Succeeded",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": [
{
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnections/peexample01",
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
},
"groupIds": [
"groupId"
]
}
}
]
}
}
]
Expand Down
46 changes: 44 additions & 2 deletions .../Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Accounts/Accounts_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,28 @@
"type": "Microsoft.DeviceUpdate/accounts",
"properties": {
"provisioningState": "Succeeded",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": [
{
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnections/peexample01",
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
},
"groupIds": [
"groupId"
]
}
}
]
},
"tags": {
"tagKey": "tagValue"
Expand All @@ -39,7 +60,28 @@
},
"properties": {
"provisioningState": "Created",
"hostName": "contoso.api.adu.microsoft.com"
"hostName": "contoso.api.adu.microsoft.com",
"privateEndpointConnections": [
{
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.DeviceUpdate/accounts/contoso/privateEndpointConnections/peexample01",
"name": "peexample01",
"type": "Microsoft.DeviceUpdate/accounts/privateEndpointConnections",
"properties": {
"provisioningState": "Succeeded",
"privateEndpoint": {
"id": "/subscriptions/00000000-0000-0000-0000-000000000000/resourceGroups/test-rg/providers/Microsoft.Network/privateEndpoints/peexample01"
},
"privateLinkServiceConnectionState": {
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
},
"groupIds": [
"groupId"
]
}
}
]
},
"tags": {
"tagKey": "tagValue"
Expand Down
34 changes: 34 additions & 0 deletions ...e-manager/Microsoft.DeviceUpdate/preview/2020-03-01-preview/examples/Operations_List.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
{
"parameters": {
"api-version": "2020-03-01-preview"
},
"responses": {
"200": {
"body": {
"nextLink": "string",
"value": [
{
"name": "Microsoft.DeviceUpdate/accounts/read",
"isDataAction": false,
"display": {
"provider": "Microsoft.DeviceUpdate",
"resource": "Device Update Account",
"operation": "Get/List Accounts",
"description": "Returns the list of Device Update Accounts"
}
},
{
"name": "Microsoft.DeviceUpdate/accounts/write",
"isDataAction": false,
"display": {
"provider": "Microsoft.DeviceUpdate",
"resource": "Device Update Account",
"operation": "Create/Update Account",
"description": "Creates or updates a Device Update Account"
}
}
]
}
}
}
}
5 changes: 4 additions & 1 deletion ...preview/examples/PrivateEndpointConnections/PrivateEndpointConnection_CreateOrUpdate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,10 @@
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
}
},
"groupIds": [
"groupId"
]
}
}
}
Expand Down
5 changes: 4 additions & 1 deletion ...2020-03-01-preview/examples/PrivateEndpointConnections/PrivateEndpointConnection_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
}
},
"groupIds": [
"groupId"
]
}
}
}
Expand Down
5 changes: 4 additions & 1 deletion ...-preview/examples/PrivateEndpointConnections/PrivateEndpointConnection_ListByAccount.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@
"status": "Approved",
"description": "Auto-Approved",
"actionsRequired": "None"
}
},
"groupIds": [
"groupId"
]
}
}
]
Expand Down
Loading