Skip to content

Fix mTempFiles being null when inside a tab view on Android #699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mystborn wants to merge 2 commits into from
Closed

Fix mTempFiles being null when inside a tab view on Android #699

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20f39b8
Fix mTempFiles being null when inside a tab view on Android
Feb 3, 2025
bcf5a90
Merge branch 'master' into android-tabs-fix
mystborn Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions android/src/main/java/com/pdftron/reactnative/views/DocumentView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2280,6 +2280,10 @@ protected void onAttachedToWindow() {
// TODO, update base64 when ViewerBuilder supports byte array
Uri fileUri = ReactUtils.getUri(getContext(), mDocumentPath, mIsBase64, mBase64Extension);

if (mTempFiles == null) {
mTempFiles = new ArrayList<>();
}

if (fileUri != null) {
if (mIsBase64) {
mTempFiles.add(new File(fileUri.getPath()));
Expand Down