Fix mTempFiles being null when inside a tab view on Android #699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a DocumentView is inside of a BottomTabNavigator from
@react-navigation/bottom-tabs, it will be detached from the window without being completely destroyed. The next time the user goes to the tab, the app will crash because mTempFiles was set to null inside ofonDetachedFromWindowpdftron-react-native/android/src/main/java/com/pdftron/reactnative/views/DocumentView.java
Line 2356 in 642b707
but onAttachedToWindow still tries to read it:
pdftron-react-native/android/src/main/java/com/pdftron/reactnative/views/DocumentView.java
Line 2285 in 642b707
To fix, I just added a safety check to make sure the field is initialized before use inside of
onAttachedToWindow.