Allow for using consumers jest config #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzarcon
reviewed
Mar 24, 2021
| import path from 'path'; | ||
|
|
||
| export const checkFileExists = (resolutionPath: string) => { | ||
| if (existsSync(path.resolve(__dirname, resolutionPath))) { |
Owner
There was a problem hiding this comment.
we have a similar logic in src/utils/createFile.ts I'd recommend extracting that into own util and not using the sync version:
import { promisify } from 'util';
import {exists} from 'fs'
const existFile = (path: string) => {
return promisify(fs.exists)(path);
}
zzarcon
reviewed
Mar 24, 2021
| const jestBin = binPath('jest'); | ||
| const configPath = path.resolve(__dirname, '../../jest.config.js'); | ||
|
|
||
| const upperJestPath = '../../../../jest.config.js'; |
Owner
There was a problem hiding this comment.
Also it will be nice to have a util to resolve user (or upper) path
import {consumerPath} from '../utils/'
const upperJestPath = consumerPath('jest.config.js');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the the consumer of this repo to specify a
jest.config.jsfile in the root of their own repo. If it is present then it will be used. Otherwise we fallback to thejest.config.jswhich is present in this package.I've tested this using yalc and https://github.com/AdilBhayani/Date-time-convertor.