After a successful upload, the generateId is no return #44
+7
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Better Auth]: [Drizzle Adapter] - You are trying to create a record with an id. This is not allowed as we handle id generation for you. The id will be ignored.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a warning from the Drizzle Adapter by removing the manual ID setting when creating database records during file uploads. The adapter auto-generates IDs and rejects manual ID specification.
Key changes:
- Removed explicit
idfield fromadapter.create()call during file upload - Captured the returned database record to access the adapter-generated ID
- Updated response to use the new database-generated ID instead of the pre-generated one
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Hi @MagnumGoYB ! Sorry for delay busy work week will check this out during the weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the manual setting of id when creating records via the Drizzle Adapter to prevent the following warning: