Allow SAML_USERS_LOOKUP_ATTRIBUTE[1] to be callable #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neitsch
changed the title
Member
shepdelacreme
left a comment
shepdelacreme
left a comment
There was a problem hiding this comment.
Looks pretty straightforward. I left a few comments. Can you add some documentation around the callable and how to use this?
| lookup_res = lookup_val(saml_auth, final_map) | ||
| else: | ||
| lookup_map = {lookup_attr[0]: final_map[lookup_attr[1]]} | ||
| final_map[lookup_val] |
Member
There was a problem hiding this comment.
Should this be assigning final_map[lookup_val] to lookup_res?
| if lookup_val == "NameId": | ||
| lookup_res = saml_auth.get_nameid() | ||
| elif callable(lookup_val): | ||
| lookup_res = lookup_val(saml_auth, final_map) |
Member
There was a problem hiding this comment.
It looks like the callable will have a standard signature. Can we get this documented and an example added for how to use this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements my request from #44 .
SAML_USERS_LOOKUP_ATTRIBUTE[1]can now be a callable. That allows to construct more complex values for the user id based on multiple attributes if needed.Unfortunately no tests cover this part of the code.