Fix SimplePitchingSplit error: Add missing age and caughtstealingpercentage fields #233
+6
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Split Fixes zero-sum-seattle#232 The MLB API now includes 'age' and 'caughtstealingpercentage' fields in pitcher statistics responses. These fields were missing from the SimplePitchingSplit dataclass, causing TypeError when trying to initialize the object with API response data. Changes: - Added age: Optional[int] = None to SimplePitchingSplit - Added caughtstealingpercentage: Optional[str] = None to SimplePitchingSplit - Updated docstring to document the new age field Tested with player ID 641793 which consistently reproduced the issue. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Updates the SimplePitchingSplit class docstring to include documentation for the caughtstealingpercentage field that was added in the previous commit. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ageandcaughtstealingpercentagefields in SimplePitchingSplit dataclassChanges Made
age: Optional[int] = Noneto SimplePitchingSplitcaughtstealingpercentage: Optional[str] = Noneto SimplePitchingSplitTesting
Background
The MLB API has added new statistical fields to pitcher data responses. The existing SimplePitchingSplit dataclass was missing these fields, causing crashes when processing current API responses.
🤖 Generated with Claude Code