Skip to content

update quickstart to add k3d #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FxKu merged 1 commit into from Feb 15, 2021
Merged

update quickstart to add k3d #1334

FxKu merged 1 commit into from Feb 15, 2021

Conversation

@ghost
Copy link

@ghost ghost commented Jan 27, 2021 •
edited by FxKu
Loading

add info on k3s 🙏🏼

closes #1292

@ghost
Copy link
Author

ghost commented Jan 27, 2021

Or would it be better to list k3d as a more light-weight docker alternative to KiND?

@FxKu
Copy link
Member

FxKu commented Jan 27, 2021

Hm , yeah the description is a bit vague. I have no experience with k3s. How can I (easily) test it locally? Would be good if the short description addresses this.

@ghost
Copy link
Author

ghost commented Jan 31, 2021

Hm , yeah the description is a bit vague. I have no experience with k3s. How can I (easily) test it locally? Would be good if the short description addresses this.

I switched the description to k3d and added more detail. To test locally install k3d, start docker, run k3d cluster create and then install the operator.

FxKu
FxKu reviewed Feb 1, 2021
View reviewed changes
docs/quickstart.md Outdated
Comment on lines 14 to 17
Copy link
Member

@FxKu FxKu Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [kind](https://kind.sigs.k8s.io/), which allows creating multi-nodes K8s
clusters running on Docker (requires Docker)
* [k3d](https://k3d.io), which allows creating multi-node K8s clusters running
under Docker (requires Docker)
* [kind](https://kind.sigs.k8s.io/) or [k3d](https://k3d.io), which allow creating multi-node K8s
clusters running on Docker (requires Docker)

Copy link
Member

@FxKu FxKu Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets combine it when it does the same

Copy link
Author

@ghost ghost Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@FxKu FxKu added this to the 1.7 milestone Feb 1, 2021
@ghost ghost changed the title update quickstart to add k3s update quickstart to add k3d Feb 3, 2021
@ghost
Copy link
Author

ghost commented Feb 3, 2021

will squash when ready

@FxKu
Copy link
Member

FxKu commented Feb 8, 2021

👍

1 similar comment
@Jan-M
Copy link
Member

Jan-M commented Feb 8, 2021

👍

@ghost
Copy link
Author

ghost commented Feb 9, 2021

squashed. ready for merge

@FxKu
Copy link
Member

FxKu commented Feb 9, 2021

wasn't necessary. We can squash on merge. Now we have to approve again, but could have told you 😃

@FxKu
Copy link
Member

FxKu commented Feb 9, 2021

👍

1 similar comment
@sdudoladov
Copy link
Member

sdudoladov commented Feb 15, 2021

👍

@FxKu FxKu merged commit 137fbbf into zalando:master Feb 15, 2021
@ghost ghost deleted the patch-1 branch February 16, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@avaczi avaczi Awaiting requested review from avaczi

@CyberDem0n CyberDem0n Awaiting requested review from CyberDem0n

@erthalion erthalion Awaiting requested review from erthalion

@Jan-M Jan-M Awaiting requested review from Jan-M Jan-M is a code owner

@RafiaSabih RafiaSabih Awaiting requested review from RafiaSabih

@sdudoladov sdudoladov Awaiting requested review from sdudoladov sdudoladov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.6.1

Development

Successfully merging this pull request may close these issues.

Quickstart Prerequisite Suggestions

3 participants

@FxKu @Jan-M @sdudoladov