Skip to content

Conversation

@vgvoleg
Copy link
Collaborator

@vgvoleg vgvoleg commented Dec 11, 2025

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the ability to propagate YDB RetrySettings through SQLAlchemy connections, enabling users to customize retry behavior for database operations. This extends the existing pattern used for ydb_request_settings to also support ydb_retry_settings.

  • Implements YdbRetrySettingsCharacteristic following the same pattern as YdbRequestSettingsCharacteristic
  • Adds getter/setter/reset methods for retry settings in both the dialect and adapter layers
  • Updates the minimum ydb-dbapi version requirement to 0.1.16 to support the new retry settings functionality

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
ydb_sqlalchemy/sqlalchemy/dbapi_adapter.py Adds set_ydb_retry_settings and get_ydb_retry_settings methods to the adapted connection class
ydb_sqlalchemy/sqlalchemy/init.py Implements YdbRetrySettingsCharacteristic class, adds corresponding dialect methods, and registers the characteristic in the connection characteristics dictionary
requirements.txt Updates minimum ydb-dbapi version from 0.1.10 to 0.1.16

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vgvoleg vgvoleg merged commit 38a767d into main Dec 11, 2025
12 checks passed
@vgvoleg vgvoleg deleted the retry_settings branch December 11, 2025 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants