Skip to content

Conversation

@vgvoleg
Copy link
Collaborator

@vgvoleg vgvoleg commented Oct 23, 2025

No description provided.

@vgvoleg vgvoleg requested a review from Copilot October 23, 2025 11:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for YDB's extended date/time types: Date32, DateTime64, and Timestamp64, which allow representation of dates and timestamps beyond the range of standard Date, DateTime, and Timestamp types.

Key Changes:

  • Added three new type classes (YqlDate32, YqlDateTime64, YqlTimestamp64) that extend the existing date/time types
  • Registered these new types in the type system with appropriate visitor methods and YDB type mappings
  • Added test coverage for the new types, including tests with dates before the Unix epoch (1969)

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ydb_sqlalchemy/sqlalchemy/types.py Exports the three new date/time type classes
ydb_sqlalchemy/sqlalchemy/datetime_types.py Defines YqlDate32, YqlDateTime64, and YqlTimestamp64 classes
ydb_sqlalchemy/sqlalchemy/compiler/base.py Adds visitor methods and YDB type mappings for the new types
ydb_sqlalchemy/sqlalchemy/init.py Registers YDB primitive type mappings and contains debug print statements
test/test_suite.py Adds test classes for the new date/time types with dates before 1970

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vgvoleg vgvoleg force-pushed the extended_dates_format branch from 84584e6 to 917dafd Compare October 23, 2025 11:25
@vgvoleg vgvoleg requested a review from Copilot October 23, 2025 12:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vgvoleg vgvoleg force-pushed the extended_dates_format branch from 917dafd to 58dc84b Compare October 23, 2025 12:57
@vgvoleg vgvoleg force-pushed the extended_dates_format branch from 58dc84b to 2c16b6b Compare October 23, 2025 14:10
@vgvoleg vgvoleg requested a review from Copilot October 23, 2025 14:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@vgvoleg vgvoleg merged commit 2439965 into main Oct 24, 2025
6 checks passed
@vgvoleg vgvoleg deleted the extended_dates_format branch October 24, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants