-
Notifications
You must be signed in to change notification settings - Fork 12
Date32, Datetime64 and Timestamp64 support #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for YDB's extended date/time types: Date32, DateTime64, and Timestamp64, which allow representation of dates and timestamps beyond the range of standard Date, DateTime, and Timestamp types.
Key Changes:
- Added three new type classes (
YqlDate32,YqlDateTime64,YqlTimestamp64) that extend the existing date/time types - Registered these new types in the type system with appropriate visitor methods and YDB type mappings
- Added test coverage for the new types, including tests with dates before the Unix epoch (1969)
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ydb_sqlalchemy/sqlalchemy/types.py | Exports the three new date/time type classes |
| ydb_sqlalchemy/sqlalchemy/datetime_types.py | Defines YqlDate32, YqlDateTime64, and YqlTimestamp64 classes |
| ydb_sqlalchemy/sqlalchemy/compiler/base.py | Adds visitor methods and YDB type mappings for the new types |
| ydb_sqlalchemy/sqlalchemy/init.py | Registers YDB primitive type mappings and contains debug print statements |
| test/test_suite.py | Adds test classes for the new date/time types with dates before 1970 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
84584e6 to
917dafd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
917dafd to
58dc84b
Compare
58dc84b to
2c16b6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 7 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.