Add integration tests for Decimal scanning in query and database/sql clients #1938
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue requests support for scanning YDB Decimal values using
types.Decimalas the destination type in both query client and database/sql. This functionality already exists but lacked test coverage.Changes
tests/integration/decimal_scan_test.gowith comprehensive integration tests:row.Scan(&decimal)with various precision/scale combinations, negative values, NULL handlingUsage
No implementation changes needed - the underlying support in
internal/value/value.go(line 615-619) andinternal/table/scanner/scanner.go(line 900-901) already handlesdecimal.Decimaltype casting correctly.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
invalid_host/tmp/go-build2219246829/b548/credentials.test -test.testlogfile=/tmp/go-build2219246829/b548/testlog.txt -test.paniconexit0 -test.timeout=10m0s -test.short=true(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.