fix: query results improvements #3224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seb33300
commented
Apr 3, 2025
| * Count filtered items. | ||
| */ | ||
| protected function filteredCount(): int | ||
| public function filteredCount(): int |
Contributor
Author
There was a problem hiding this comment.
I modified the visibility of that method to public because the totalCount() method is also public.
yajra
approved these changes
Apr 7, 2025
Owner
|
Released on https://github.com/yajra/laravel-datatables/releases/tag/v12.0.1 🚀 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a custom action where I need to return a json with complex manipulation on the data.
In that action I need to access the query results.
This is an improvement to prevent the query to be triggered twice.