-
-
Notifications
You must be signed in to change notification settings - Fork 855
feat: Laravel v12 Compatibility #3217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@swooningfish: looks like the README could do with a new entry under Laravel Version Compatibility. |
Thanks have updated. |
- Removed ^11 references for all the packages to have the same Laravel version constraint. + Added back in illuminate/view and set the version constraint to ^12
|
amened with pull request comments. |
|
laravel-datatables/composer.json Lines 54 to 56 in b48eb61
Does the branch alias also need to be bumped? Line 7 in b48eb61
And the badge |
Thanks, have added in the badge for v12 Not sure about the branch alias as i think the branch needs to be available on the remote, but can amend if required. |
Sure, one for Yajra then, it was done last time anyway: c28eca3 |
|
Any update? |
|
@resslinger: I would suggest giving @yajra some time to consider this PR. They're +8h (making it 10pm) and it's not even the middle of the week. 🏄🏻♂️ |
Co-authored-by: Sébastien Alfaiate <seb33300@hotmail.com>
|
Unfortunately, the build is still failing, this time because of Larastan 2 not compatible with Laravel 12: Larastan needs to be upgraded to 3.1.0
|
|
yajra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge, will fix phpstan issues on another PR. Thanks!
|
Could you tag a new release please? |




Laravel 12 Dependencies