Skip to content

Conversation

@loadkpi
Copy link

@loadkpi loadkpi commented Jul 2, 2025

@Envek there's some code duplication between the new and legacy implementations. What is you opinion: should I DRY this up by extracting shared methods, or keep the implementations separate for simplicity?

@numbata
Copy link

numbata commented Nov 19, 2025

@Envek is there a way to move this forward toward a release somehow?

Copy link
Member

@Envek Envek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loadkpi, thank you very much for your pull request and sorry for the long wait!

I think that there is much value in keeping the old implementation at all. Let's drop all legacy stuff and version checks and instead bump minimum graphql-ruby version requirement to 2.0 (that's where current Tracing API appeared if I'm right)

For yabeda-graphql users it should be completely unnoticeable as all changes are hidden behind use Yabeda::GraphQL hook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warning of schema.instrument, need to refactor to use .trace_with instead

3 participants